----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14880/#review27829 -----------------------------------------------------------
Ship it! I think it's best to keep the message about the missing masters file on STDERR and that Sean's comments addressed Tubbs's other questions, so I'm +1 on the patch once the change that's now in ACCUMULO-1810 is removed from this patch. - Joey Echeverria On Oct. 23, 2013, 7:08 p.m., Sean Busbey wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/14880/ > ----------------------------------------------------------- > > (Updated Oct. 23, 2013, 7:08 p.m.) > > > Review request for accumulo. > > > Bugs: ACCUMULO-1785 > https://issues.apache.org/jira/browse/ACCUMULO-1785 > > > Repository: accumulo > > > Description > ------- > > Updates config.sh to skip automagic standalone mode and avoid writing to the > local filesystem given an optional environment variable. Adds additional > error handling since this changes the invariant that a conf/masters file will > exist. > > > Diffs > ----- > > bin/config.sh 9277406 > > Diff: https://reviews.apache.org/r/14880/diff/ > > > Testing > ------- > > functional tests > starting w/o env variable set and no master/slaves correctly started in > standalone mode. > starting w/env variable and no required variables and no master/slaves > correctly complained and failed. > starting w/env variable and required variables and no master/slaves correctly > init w/o writing crap, correctly failed to use start-all > starting with a normal cluster config > > > Thanks, > > Sean Busbey > >
