> On Oct. 29, 2013, 3:25 p.m., kturner wrote: > > core/src/main/java/org/apache/accumulo/core/client/ZooKeeperInstance.java, > > line 102 > > <https://reviews.apache.org/r/14972/diff/1/?file=371853#file371853line102> > > > > I think I advocated somewhere for removing this method, because its not > > scaleable for every feature to have a seat at the table in the constructor. > > The constructor that takes the config object nicely covers this use case. > > John Vines wrote: > I was under the impression that this fell under ACCUMULO-1726 > > kturner wrote: > How is adding a redundant method to the API now related to 1726? > > John Vines wrote: > Misunderstood, agree with your assessment. > > Michael Berman wrote: > I did remove most of the constructors I added, and I agree it's better > without the bloat, but I am a little concerned about discoverability. I > guess it depends what our long-term plan is. If we're expecting that > everyone will always use the single-argument ClientConfiguration constructor, > then maybe we should start deprecating the others (and then discoverability > is less of a concern because people will see the options on > ClientConfiguration). But if we think (String instanceName, String > zooKeepers) will continue to be the usual constructor, then I think it does > make sense to have the most common options available in a variant of that one > (although I think it's good not to have every possible permutation of > switches cluttering up the interface).
I think pushing towards the ClientConfiguration constructor is the way to go. I see an argument for keeping the very simple (String instanceName, String zooKeepers) for examples, but I'm +0 on it. > On Oct. 29, 2013, 3:25 p.m., kturner wrote: > > core/src/main/java/org/apache/accumulo/core/conf/AccumuloConfiguration.java, > > line 161 > > <https://reviews.apache.org/r/14972/diff/1/?file=371870#file371870line161> > > > > there is also $ACCUMULO_CONF_DIR (not sure if I have the var name > > exactly correct) > > Michael Berman wrote: > I was wondering about this... The code that I generalized that from only > paid attention to $ACCUMULO_HOME and not the other one, and as I was looking > through the codebase it seemed about 50/50 whether a given code path > respected $ACCUMULO_CONF_DIR. What is the intention there? Is the plan for > both to co-exist (and $ACCUMULO_CONF_DIR overrides $ACCUMULO_HOME/conf)? > Should we go through and make sure it's universally supported? everything should be using $ACCUMULO_CONF_DIR. if there are places that don't contain it, please file a bug that points to as many of them as possible. If you are adding in new code, please use it. There are some existing bugs for it not being set correctly in tests. I believe one of config.sh or bin/accumulo is responsible for handling the fall back to $ACCUMULO_HOME/conf when $ACCUMULO_CONF_DIR doesn't exist. > On Oct. 29, 2013, 3:25 p.m., kturner wrote: > > minicluster/src/main/java/org/apache/accumulo/minicluster/MiniAccumuloConfig.java, > > line 385 > > <https://reviews.apache.org/r/14972/diff/1/?file=371882#file371882line385> > > > > Mini is intended to be user facing and allow user to test their code > > against Accumulo. We keep exposing methods in the minicluster public API > > inorder for Accumulo to test Accumulo. I worry that the more we expose in > > its API the more we will box ourselves in for future changes to mini (like > > speeding it up some way). > > > > This is a general concern I have, not specific to this change. This > > change is following the general trend for mini. I have not had time to > > pursue, but I have wondered if it would be worthwhile to create a mini for > > internal use and one for external use (with a more minimal API). This may > > not be worthwhile. > > > > John Vines wrote: > This sounds like something that should be written up in it's own ticket > > Michael Berman wrote: > I'm not sure I agree that this is exclusive to us testing accumulo... On > a big cluster, system props can be set in accumulo-env.sh, so it makes sense > to me that there would also be a way to set them in a minicluster. > > That said, I don't think we actually need it for the SSL changeset quite > yet. I added it so that I could test JSSE, but it turns out that doesn't > work at all with the ZK/JSSE incompatibility, so if it's controversial we > could take it out. But I'll want it back in if ZOOKEEPER-1554 gets addressed > and we want to flesh out JSSE support. +1 for removal. I'd rather see discussion on the dev@ list about Mini internal-vs-external than a ticket. > On Oct. 29, 2013, 3:25 p.m., kturner wrote: > > server/src/main/resources/web/flot/jquery.flot.js, line 1560 > > <https://reviews.apache.org/r/14972/diff/1/?file=371891#file371891line1560> > > > > why was this change made? What does it have to do w/ ssl? > > Michael Berman wrote: > It has nothing to do with this particular changeset except that I hate > seeing errors in my IDE while I'm working on things. I have no problem > taking it out of this commit, but I would love if a committer could fix it > one way or another. Please put formatting / unrelated errors into an different JIRA/commit. - Sean ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14972/#review27675 ----------------------------------------------------------- On Oct. 31, 2013, 2:35 p.m., John Vines wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/14972/ > ----------------------------------------------------------- > > (Updated Oct. 31, 2013, 2:35 p.m.) > > > Review request for accumulo and Michael Berman. > > > Bugs: ACCUMULO-1009 > https://issues.apache.org/jira/browse/ACCUMULO-1009 > > > Repository: accumulo > > > Description > ------- > > Michael Berman's October 13 patch for ACCUMULO-1009 > > > Diffs > ----- > > .gitignore 1ffa452 > core/src/main/java/org/apache/accumulo/core/cli/ClientOpts.java 9247d56 > core/src/main/java/org/apache/accumulo/core/client/ZooKeeperInstance.java > 5b5d041 > > core/src/main/java/org/apache/accumulo/core/client/impl/ConditionalWriterImpl.java > bb5987d > core/src/main/java/org/apache/accumulo/core/client/impl/MasterClient.java > 32c80f9 > core/src/main/java/org/apache/accumulo/core/client/impl/ServerClient.java > 218bd36 > > core/src/main/java/org/apache/accumulo/core/client/impl/TabletServerBatchReaderIterator.java > 0376304 > > core/src/main/java/org/apache/accumulo/core/client/impl/TabletServerBatchWriter.java > 0dd86bf > > core/src/main/java/org/apache/accumulo/core/client/impl/ThriftTransportKey.java > f07139d > > core/src/main/java/org/apache/accumulo/core/client/impl/ThriftTransportPool.java > e7dabb5 > > core/src/main/java/org/apache/accumulo/core/client/mapred/AccumuloInputFormat.java > bbbd0c3 > > core/src/main/java/org/apache/accumulo/core/client/mapred/AccumuloOutputFormat.java > 908b8b3 > > core/src/main/java/org/apache/accumulo/core/client/mapred/AccumuloRowInputFormat.java > fe5003b > > core/src/main/java/org/apache/accumulo/core/client/mapred/InputFormatBase.java > c796cd2 > > core/src/main/java/org/apache/accumulo/core/client/mapreduce/AccumuloInputFormat.java > 1cbb606 > > core/src/main/java/org/apache/accumulo/core/client/mapreduce/AccumuloOutputFormat.java > 727bfec > > core/src/main/java/org/apache/accumulo/core/client/mapreduce/AccumuloRowInputFormat.java > 992990d > > core/src/main/java/org/apache/accumulo/core/client/mapreduce/InputFormatBase.java > 13f9708 > > core/src/main/java/org/apache/accumulo/core/client/mapreduce/lib/util/ConfiguratorBase.java > 73405c5 > core/src/main/java/org/apache/accumulo/core/conf/AccumuloConfiguration.java > 28cb0bd > core/src/main/java/org/apache/accumulo/core/conf/ClientConfiguration.java > PRE-CREATION > core/src/main/java/org/apache/accumulo/core/conf/Property.java b6fbdd2 > core/src/main/java/org/apache/accumulo/core/security/Credentials.java > 0552e7e > core/src/main/java/org/apache/accumulo/core/security/SecurityUtil.java > 8add1a7 > > core/src/main/java/org/apache/accumulo/core/security/ssl/SslConnectionParams.java > PRE-CREATION > core/src/main/java/org/apache/accumulo/core/util/ThriftUtil.java e8dd6a2 > core/src/main/java/org/apache/accumulo/core/util/shell/Shell.java 4140c8c > core/src/main/java/org/apache/accumulo/core/util/shell/ShellOptionsJC.java > cb1f1c8 > > core/src/test/java/org/apache/accumulo/core/conf/ClientConfigurationTest.java > PRE-CREATION > > core/src/test/java/org/apache/accumulo/core/util/shell/ShellSetInstanceTest.java > 23ca13a > > minicluster/src/main/java/org/apache/accumulo/minicluster/MiniAccumuloCluster.java > 77776df > > minicluster/src/main/java/org/apache/accumulo/minicluster/MiniAccumuloConfig.java > 0b6c42c > > minicluster/src/main/java/org/apache/accumulo/minicluster/MiniAccumuloInstance.java > 540d7ae > > minicluster/src/test/java/org/apache/accumulo/minicluster/MiniAccumuloClusterTest.java > 3e749ab > > server/src/main/java/org/apache/accumulo/server/cli/ClientOnDefaultTable.java > 53f5ac2 > > server/src/main/java/org/apache/accumulo/server/cli/ClientOnRequiredTable.java > e9e9bf1 > server/src/main/java/org/apache/accumulo/server/cli/ClientOpts.java 6f3516a > server/src/main/java/org/apache/accumulo/server/client/BulkImporter.java > a04765f > > server/src/main/java/org/apache/accumulo/server/gc/SimpleGarbageCollector.java > 817aa74 > server/src/main/java/org/apache/accumulo/server/util/TServerUtils.java > 1df17fe > server/src/main/resources/web/flot/jquery.flot.js aabc544 > test/pom.xml 8343bb2 > test/src/test/java/org/apache/accumulo/test/ConditionalWriterTest.java > 633ea76 > test/src/test/java/org/apache/accumulo/test/ShellServerIT.java 4fbd293 > test/src/test/java/org/apache/accumulo/test/functional/AbstractMacIT.java > f1a651d > test/src/test/java/org/apache/accumulo/test/functional/BulkIT.java 607f2a5 > test/src/test/java/org/apache/accumulo/test/functional/ConcurrencyIT.java > c3d3160 > > test/src/test/java/org/apache/accumulo/test/functional/ConfigurableMacIT.java > c34fff5 > test/src/test/java/org/apache/accumulo/test/functional/MapReduceIT.java > 69825bc > test/src/test/java/org/apache/accumulo/test/functional/ShutdownIT.java > 8d58821 > test/src/test/java/org/apache/accumulo/test/functional/SimpleMacIT.java > 4a37d82 > test/src/test/java/org/apache/accumulo/test/functional/SslIT.java > PRE-CREATION > > test/src/test/java/org/apache/accumulo/test/functional/SslWithClientAuthIT.java > PRE-CREATION > test/src/test/java/org/apache/accumulo/test/functional/SslWithJsseIT.java > PRE-CREATION > test/src/test/java/org/apache/accumulo/test/util/CertUtils.java > PRE-CREATION > test/src/test/java/org/apache/accumulo/test/util/CertUtilsTest.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/14972/diff/ > > > Testing > ------- > > > Thanks, > > John Vines > >
