> On Nov. 1, 2013, 9:37 p.m., Christopher Tubbs wrote:
> > core/src/main/java/org/apache/accumulo/core/client/mapreduce/lib/util/ConfiguratorBase.java,
> > line 302
> > <https://reviews.apache.org/r/14972/diff/1/?file=371869#file371869line302>
> >
> > There's really too many methods here. If we're going to provide an
> > alternate way to set configuration on a M/R job, we shouldn't take some
> > properties, plus a configuration object with other properties... we should
> > just take the configuration object and expect it to include all the
> > necessary options.
>
> John Vines wrote:
> Please see discussion https://reviews.apache.org/r/14972/#comment53742
>
> Christopher Tubbs wrote:
> I'll retract this comment. I was thinking this was public API, but it's
> not. It's in the utility class.
>
> Michael Berman wrote:
> I did end up cleaning it up following that discussion upthread, since it
> was bugging me anyway.
>
> Are you sure this isn't in the public API, though? I figured this is the
> method people would use in their own MR jobs, for passing configuration to
> accumulo's In/OutputFormats. If I've misunderstood how this code gets
> consumed, and it's not really public, I'll skip the deprecation cycle and
> just get rid of the old ones now.
>
> Christopher Tubbs wrote:
> ConfiguratorBase, along with all the classes in this util package, is an
> internal util class shared between mapred and mapreduce implementations for
> the implementation of the static configurator methods on the specific
> {Input,Output}Format. The public API for this is the static methods on the
> actual InputFormat and OutputFormat classes.
>
> The classes could be consumed by alternate implementations of jobs, like
> those in Hama BSP, but it would be risky to rely on them, as I never intended
> them to be part of the public API. That's why I put them in a util
> sub-package and called them inside the static configurator methods.
>
> The fact that they take the "implementingClass" parameter should also be
> an indicator they are internal helper code, and not public API.
Oh yeah, of course...I was confusing the methods on ConfiguratorBase with the
similar ones that call them from the {Input,Output}Formats.
Do you think it's worth deprecating those methods on ConfiguratorBase anyway,
or should I just drop the ones that are no longer used?
- Michael
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14972/#review28034
-----------------------------------------------------------
On Oct. 31, 2013, 2:35 p.m., John Vines wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14972/
> -----------------------------------------------------------
>
> (Updated Oct. 31, 2013, 2:35 p.m.)
>
>
> Review request for accumulo and Michael Berman.
>
>
> Bugs: ACCUMULO-1009
> https://issues.apache.org/jira/browse/ACCUMULO-1009
>
>
> Repository: accumulo
>
>
> Description
> -------
>
> Michael Berman's October 13 patch for ACCUMULO-1009
>
>
> Diffs
> -----
>
> .gitignore 1ffa452
> core/src/main/java/org/apache/accumulo/core/cli/ClientOpts.java 9247d56
> core/src/main/java/org/apache/accumulo/core/client/ZooKeeperInstance.java
> 5b5d041
>
> core/src/main/java/org/apache/accumulo/core/client/impl/ConditionalWriterImpl.java
> bb5987d
> core/src/main/java/org/apache/accumulo/core/client/impl/MasterClient.java
> 32c80f9
> core/src/main/java/org/apache/accumulo/core/client/impl/ServerClient.java
> 218bd36
>
> core/src/main/java/org/apache/accumulo/core/client/impl/TabletServerBatchReaderIterator.java
> 0376304
>
> core/src/main/java/org/apache/accumulo/core/client/impl/TabletServerBatchWriter.java
> 0dd86bf
>
> core/src/main/java/org/apache/accumulo/core/client/impl/ThriftTransportKey.java
> f07139d
>
> core/src/main/java/org/apache/accumulo/core/client/impl/ThriftTransportPool.java
> e7dabb5
>
> core/src/main/java/org/apache/accumulo/core/client/mapred/AccumuloInputFormat.java
> bbbd0c3
>
> core/src/main/java/org/apache/accumulo/core/client/mapred/AccumuloOutputFormat.java
> 908b8b3
>
> core/src/main/java/org/apache/accumulo/core/client/mapred/AccumuloRowInputFormat.java
> fe5003b
>
> core/src/main/java/org/apache/accumulo/core/client/mapred/InputFormatBase.java
> c796cd2
>
> core/src/main/java/org/apache/accumulo/core/client/mapreduce/AccumuloInputFormat.java
> 1cbb606
>
> core/src/main/java/org/apache/accumulo/core/client/mapreduce/AccumuloOutputFormat.java
> 727bfec
>
> core/src/main/java/org/apache/accumulo/core/client/mapreduce/AccumuloRowInputFormat.java
> 992990d
>
> core/src/main/java/org/apache/accumulo/core/client/mapreduce/InputFormatBase.java
> 13f9708
>
> core/src/main/java/org/apache/accumulo/core/client/mapreduce/lib/util/ConfiguratorBase.java
> 73405c5
> core/src/main/java/org/apache/accumulo/core/conf/AccumuloConfiguration.java
> 28cb0bd
> core/src/main/java/org/apache/accumulo/core/conf/ClientConfiguration.java
> PRE-CREATION
> core/src/main/java/org/apache/accumulo/core/conf/Property.java b6fbdd2
> core/src/main/java/org/apache/accumulo/core/security/Credentials.java
> 0552e7e
> core/src/main/java/org/apache/accumulo/core/security/SecurityUtil.java
> 8add1a7
>
> core/src/main/java/org/apache/accumulo/core/security/ssl/SslConnectionParams.java
> PRE-CREATION
> core/src/main/java/org/apache/accumulo/core/util/ThriftUtil.java e8dd6a2
> core/src/main/java/org/apache/accumulo/core/util/shell/Shell.java 4140c8c
> core/src/main/java/org/apache/accumulo/core/util/shell/ShellOptionsJC.java
> cb1f1c8
>
> core/src/test/java/org/apache/accumulo/core/conf/ClientConfigurationTest.java
> PRE-CREATION
>
> core/src/test/java/org/apache/accumulo/core/util/shell/ShellSetInstanceTest.java
> 23ca13a
>
> minicluster/src/main/java/org/apache/accumulo/minicluster/MiniAccumuloCluster.java
> 77776df
>
> minicluster/src/main/java/org/apache/accumulo/minicluster/MiniAccumuloConfig.java
> 0b6c42c
>
> minicluster/src/main/java/org/apache/accumulo/minicluster/MiniAccumuloInstance.java
> 540d7ae
>
> minicluster/src/test/java/org/apache/accumulo/minicluster/MiniAccumuloClusterTest.java
> 3e749ab
>
> server/src/main/java/org/apache/accumulo/server/cli/ClientOnDefaultTable.java
> 53f5ac2
>
> server/src/main/java/org/apache/accumulo/server/cli/ClientOnRequiredTable.java
> e9e9bf1
> server/src/main/java/org/apache/accumulo/server/cli/ClientOpts.java 6f3516a
> server/src/main/java/org/apache/accumulo/server/client/BulkImporter.java
> a04765f
>
> server/src/main/java/org/apache/accumulo/server/gc/SimpleGarbageCollector.java
> 817aa74
> server/src/main/java/org/apache/accumulo/server/util/TServerUtils.java
> 1df17fe
> server/src/main/resources/web/flot/jquery.flot.js aabc544
> test/pom.xml 8343bb2
> test/src/test/java/org/apache/accumulo/test/ConditionalWriterTest.java
> 633ea76
> test/src/test/java/org/apache/accumulo/test/ShellServerIT.java 4fbd293
> test/src/test/java/org/apache/accumulo/test/functional/AbstractMacIT.java
> f1a651d
> test/src/test/java/org/apache/accumulo/test/functional/BulkIT.java 607f2a5
> test/src/test/java/org/apache/accumulo/test/functional/ConcurrencyIT.java
> c3d3160
>
> test/src/test/java/org/apache/accumulo/test/functional/ConfigurableMacIT.java
> c34fff5
> test/src/test/java/org/apache/accumulo/test/functional/MapReduceIT.java
> 69825bc
> test/src/test/java/org/apache/accumulo/test/functional/ShutdownIT.java
> 8d58821
> test/src/test/java/org/apache/accumulo/test/functional/SimpleMacIT.java
> 4a37d82
> test/src/test/java/org/apache/accumulo/test/functional/SslIT.java
> PRE-CREATION
>
> test/src/test/java/org/apache/accumulo/test/functional/SslWithClientAuthIT.java
> PRE-CREATION
> test/src/test/java/org/apache/accumulo/test/functional/SslWithJsseIT.java
> PRE-CREATION
> test/src/test/java/org/apache/accumulo/test/util/CertUtils.java
> PRE-CREATION
> test/src/test/java/org/apache/accumulo/test/util/CertUtilsTest.java
> PRE-CREATION
>
> Diff: https://reviews.apache.org/r/14972/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> John Vines
>
>
