> On Dec. 3, 2013, 6:24 p.m., kturner wrote: > > core/src/main/java/org/apache/accumulo/core/data/Mutation.java, line 609 > > <https://reviews.apache.org/r/15857/diff/2/?file=393088#file393088line609> > > > > Should mention that after this method is called a mutation can no > > longer be modfied. Also it does a defensive copy, changing the arrays > > pointed to by column update will not affect mutation > > Bill Havanki wrote: > I'll add the needed verbiage, but the behavior you're describing isn't > enforced by the class, i.e., you can still put things into a Mutation after > calling getUpdates(), they just are (silently?) ignored. Perhaps that should > be fixed?
I think it is, but I have not tried it. getUpdates() calls serialize which sets buffer to null. There is a put() method that checks if buffer is null and throws an exception. - kturner ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15857/#review29664 ----------------------------------------------------------- On Dec. 3, 2013, 7:13 p.m., Bill Havanki wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/15857/ > ----------------------------------------------------------- > > (Updated Dec. 3, 2013, 7:13 p.m.) > > > Review request for accumulo. > > > Bugs: ACCUMULO-1931 > https://issues.apache.org/jira/browse/ACCUMULO-1931 > > > Repository: accumulo > > > Description > ------- > > Javadoc additions and updates to classes in org.apache.accumulo.core.data. > > > Diffs > ----- > > core/src/main/java/org/apache/accumulo/core/data/ArrayByteSequence.java > eaa61b9950b691ed5955af3178a3aa939291e8bf > core/src/main/java/org/apache/accumulo/core/data/ByteSequence.java > 4dc921c5efc44d374032c623f50e4218aa6c7299 > core/src/main/java/org/apache/accumulo/core/data/Column.java > a56c01d6604a30153739ed1329d034e3932f2e2f > core/src/main/java/org/apache/accumulo/core/data/ColumnUpdate.java > 641ca3a740ed384ab93f4b2d3c08c928daadfb2f > core/src/main/java/org/apache/accumulo/core/data/ComparableBytes.java > ce61844375617c36ede5e0e411b439205329b023 > core/src/main/java/org/apache/accumulo/core/data/Condition.java > fc8f2bf0394ae658bacfa94804b4b81f19a0c0c2 > > core/src/main/java/org/apache/accumulo/core/data/ConstraintViolationSummary.java > 2929bc610df9352374621d29caea7732bd50847d > core/src/main/java/org/apache/accumulo/core/data/Key.java > de9e22d9ebff5442633dc578613fd7d033afc9c5 > core/src/main/java/org/apache/accumulo/core/data/KeyValue.java > cc48322f9785ad508cc7925279f5e559629f3721 > core/src/main/java/org/apache/accumulo/core/data/Mutation.java > 5e281f2bfef7e164c9f0e0c9a7132e94012d7186 > core/src/main/java/org/apache/accumulo/core/data/PartialKey.java > 2049881fe26b5f237db39a412a88e2e2017f5cc9 > core/src/main/java/org/apache/accumulo/core/data/Range.java > 70857348cefd0941e5ffcf6e5d569f09870101e4 > core/src/main/java/org/apache/accumulo/core/data/Value.java > 7d3cf8f20aa12205d25027d6ad06e4a3f6062b2e > core/src/main/java/org/apache/accumulo/core/util/UnsynchronizedBuffer.java > b640581bebbb87f1ac9a36f71275fa5dc8ef1223 > > Diff: https://reviews.apache.org/r/15857/diff/ > > > Testing > ------- > > Compiled successfully; mvn javadoc:javadoc ran with no errors from the > javadoc in this patch. > > > Thanks, > > Bill Havanki > >
