----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16043/#review29834 -----------------------------------------------------------
Ship it! Ship It! - Josh Elser On Dec. 5, 2013, 8:47 p.m., Bill Havanki wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/16043/ > ----------------------------------------------------------- > > (Updated Dec. 5, 2013, 8:47 p.m.) > > > Review request for accumulo. > > > Bugs: ACCUMULO-1959 > https://issues.apache.org/jira/browse/ACCUMULO-1959 > > > Repository: accumulo > > > Description > ------- > > Very minor change, deprecating a constructor for the Value class where a > needless double-copy of the input is performed. I also added a unit test for > Value, which really could use one. > > > Diffs > ----- > > core/src/main/java/org/apache/accumulo/core/data/Value.java > 7d3cf8f20aa12205d25027d6ad06e4a3f6062b2e > core/src/test/java/org/apache/accumulo/core/data/ValueTest.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/16043/diff/ > > > Testing > ------- > > Implemented and ran unit test before and after change, all tests pass. > > > Thanks, > > Bill Havanki > >
