----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16427/#review30769 -----------------------------------------------------------
src/core/src/main/java/org/apache/accumulo/core/client/ZooKeeperInstance.java <https://reviews.apache.org/r/16427/#comment58918> Not sure if there's something in ZooKeeperInstance that you can use, but it's excessive to take the instance ID, to find the instance name. Perhaps you can add a protected constructor that you can provide the instance name and ID since you know you calculated them correctly. - Josh Elser On Dec. 20, 2013, 9:52 p.m., Mike Drob wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/16427/ > ----------------------------------------------------------- > > (Updated Dec. 20, 2013, 9:52 p.m.) > > > Review request for accumulo. > > > Bugs: ACCUMULO-2076 > https://issues.apache.org/jira/browse/ACCUMULO-2076 > > > Repository: accumulo > > > Description > ------- > > Writing client code for retrieving zookeeper and instance information is both > tedious and error prone. It would be great to remove this boiler-plate burden > from users. > > > Diffs > ----- > > > src/core/src/main/java/org/apache/accumulo/core/client/ZooKeeperInstance.java > fcadd384cc150b8422c3f5c33970c26efe142132 > > Diff: https://reviews.apache.org/r/16427/diff/ > > > Testing > ------- > > None, yet. :) > > > Thanks, > > Mike Drob > >
