> On Jan. 20, 2014, 10:39 p.m., Bill Havanki wrote: > > src/core/src/main/java/org/apache/accumulo/core/zookeeper/ZooSession.java, > > line 112 > > <https://reviews.apache.org/r/17132/diff/1/?file=432905#file432905line112> > > > > Also check if the negativeTtl property is negative and use the default > > if it is.
Good catch. Actually, since -1 means "cache forever" should we check for that and not retry in that case? Since ZK refuses to try establishing connections if any of the passed hosts fail to resolve, I think yes? - Sean ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17132/#review32318 ----------------------------------------------------------- On Jan. 20, 2014, 10:16 p.m., Sean Busbey wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/17132/ > ----------------------------------------------------------- > > (Updated Jan. 20, 2014, 10:16 p.m.) > > > Review request for accumulo. > > > Bugs: ACCUMULO-2224 > https://issues.apache.org/jira/browse/ACCUMULO-2224 > > > Repository: accumulo > > > Description > ------- > > retries if host is not found, up to 2xZK timeout (same as other > IOExceptions), rather than bailing on any host name problem. > > > Diffs > ----- > > src/core/src/main/java/org/apache/accumulo/core/zookeeper/ZooSession.java > e64f0c52e51b9339930f6a70564fcc48031df687 > > Diff: https://reviews.apache.org/r/17132/diff/ > > > Testing > ------- > > functional + ci in progress > > > Thanks, > > Sean Busbey > >
