----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17129/#review32360 -----------------------------------------------------------
src/server/src/main/java/org/apache/accumulo/server/trace/TraceServer.java <https://reviews.apache.org/r/17129/#comment61153> What's up with the "XXX"? What does it mean? src/server/src/main/java/org/apache/accumulo/server/trace/TraceServer.java <https://reviews.apache.org/r/17129/#comment61154> Why does this need a comment? src/server/src/main/java/org/apache/accumulo/server/trace/TraceServer.java <https://reviews.apache.org/r/17129/#comment61155> Why duplicate the same code for two different exception types? src/server/src/main/java/org/apache/accumulo/server/trace/TraceServer.java <https://reviews.apache.org/r/17129/#comment61156> Why demote these from error to warning? It's unexpected behavior. If it stays a warning, don't dump the stack. It does not inform the user, and just provides more scary output to read. - Eric Newton On Jan. 20, 2014, 7:18 p.m., Sean Busbey wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/17129/ > ----------------------------------------------------------- > > (Updated Jan. 20, 2014, 7:18 p.m.) > > > Review request for accumulo and Eric Newton. > > > Bugs: ACCUMULO-2213 > https://issues.apache.org/jira/browse/ACCUMULO-2213 > > > Repository: accumulo > > > Description > ------- > > ACCUMULO-2213 Make writer recovery in the Tracer more robust. > > * Adds optional logging to TSBW closure so we can better instrument long > run tests to look for problems. > * Cleans up writer reseting in the TraceServer, avoids overly broad > catching. > * tones down log levels in TraceServer to WARN because trace information > is transient and we retry everything. > > > Diffs > ----- > > > src/core/src/main/java/org/apache/accumulo/core/client/impl/TabletServerBatchWriter.java > e18f3f96f4e0959b975399921bb7d7958c561220 > src/server/src/main/java/org/apache/accumulo/server/trace/TraceServer.java > 4d89e9c13f89e71e674875db32cf267e045d6131 > > Diff: https://reviews.apache.org/r/17129/diff/ > > > Testing > ------- > > running on cluster with injected failures now > > > Thanks, > > Sean Busbey > >
