> On Feb. 3, 2014, 7:16 p.m., kturner wrote: > > I think you should delete ArgumentChecker instead of deprecating it. Its > > not part of the public API.
Works for me. - Bill ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17674/#review33538 ----------------------------------------------------------- On Feb. 4, 2014, 9:16 a.m., Bill Havanki wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/17674/ > ----------------------------------------------------------- > > (Updated Feb. 4, 2014, 9:16 a.m.) > > > Review request for accumulo. > > > Bugs: ACCUMULO-2021 > https://issues.apache.org/jira/browse/ACCUMULO-2021 > > > Repository: accumulo > > > Description > ------- > > The ArgumentChecker offers some of the same argument checks as the > Preconditions class in Guava. This commit deprecates ArgumentChecker and > replaces its uses with calls to Preconditions, particularly > Preconditions.checkArgument(). The Validator class inside ArgumentChecker was > also promoted to a regular class with its own unit test (and I added or() and > not() methods to go with the pre-existing and()). > > I need to mention that the null checks are done with checkArgument instead of > checkNotNull because the latter throws NullPointerException, but the > ArgumentChecker checks threw IllegalArgumentException. > > > Diffs > ----- > > core/src/main/java/org/apache/accumulo/core/client/ClientConfiguration.java > a3d51cf > > core/src/main/java/org/apache/accumulo/core/client/ConditionalWriterConfig.java > f2a91ea > core/src/main/java/org/apache/accumulo/core/client/IteratorSetting.java > 7a98df2 > core/src/main/java/org/apache/accumulo/core/client/ZooKeeperInstance.java > f776a79 > > core/src/main/java/org/apache/accumulo/core/client/admin/InstanceOperationsImpl.java > a16782f > > core/src/main/java/org/apache/accumulo/core/client/admin/NamespaceOperationsImpl.java > 569a3b6 > > core/src/main/java/org/apache/accumulo/core/client/admin/SecurityOperationsImpl.java > 17feb9b > > core/src/main/java/org/apache/accumulo/core/client/admin/TableOperationsHelper.java > 843f572 > > core/src/main/java/org/apache/accumulo/core/client/admin/TableOperationsImpl.java > 4003e6f > > core/src/main/java/org/apache/accumulo/core/client/impl/BatchWriterImpl.java > 829a987 > core/src/main/java/org/apache/accumulo/core/client/impl/ConnectorImpl.java > 7d9d3ab > core/src/main/java/org/apache/accumulo/core/client/impl/MasterClient.java > 7356663 > > core/src/main/java/org/apache/accumulo/core/client/impl/MultiTableBatchWriterImpl.java > f2478d9 > core/src/main/java/org/apache/accumulo/core/client/impl/Namespaces.java > c134c04 > core/src/main/java/org/apache/accumulo/core/client/impl/OfflineScanner.java > c60e153 > core/src/main/java/org/apache/accumulo/core/client/impl/ScannerImpl.java > 6be55b6 > core/src/main/java/org/apache/accumulo/core/client/impl/ScannerOptions.java > 7641755 > core/src/main/java/org/apache/accumulo/core/client/impl/ServerClient.java > 4eb845d > core/src/main/java/org/apache/accumulo/core/client/impl/Tables.java 8a2c2c7 > core/src/main/java/org/apache/accumulo/core/client/impl/TabletLocator.java > e396d82 > > core/src/main/java/org/apache/accumulo/core/client/impl/TabletServerBatchReader.java > aee8c21 > > core/src/main/java/org/apache/accumulo/core/client/impl/ThriftTransportKey.java > 2816da7 > core/src/main/java/org/apache/accumulo/core/client/impl/Writer.java 72a050a > > core/src/main/java/org/apache/accumulo/core/client/mapreduce/lib/util/ConfiguratorBase.java > cf861ce > > core/src/main/java/org/apache/accumulo/core/client/mapreduce/lib/util/InputConfigurator.java > 270c5a1 > > core/src/main/java/org/apache/accumulo/core/client/mock/MockBatchWriter.java > d89a263 > core/src/main/java/org/apache/accumulo/core/data/Condition.java 16de324 > core/src/main/java/org/apache/accumulo/core/data/ConditionalMutation.java > c1206e5 > core/src/main/java/org/apache/accumulo/core/metadata/MetadataServicer.java > 67f1d8a > core/src/main/java/org/apache/accumulo/core/security/Authorizations.java > ab3ea68 > core/src/main/java/org/apache/accumulo/core/util/ArgumentChecker.java > 1ba133a > core/src/main/java/org/apache/accumulo/core/util/Validator.java > PRE-CREATION > core/src/test/java/org/apache/accumulo/core/util/ValidatorTest.java > PRE-CREATION > > server/base/src/main/java/org/apache/accumulo/server/trace/TraceFileSystem.java > 71cc562 > > server/master/src/main/java/org/apache/accumulo/master/FateServiceHandler.java > 7e274c0 > > Diff: https://reviews.apache.org/r/17674/diff/ > > > Testing > ------- > > Unit test for Validator passes; compiling works, full unit test passes. > > > Thanks, > > Bill Havanki > >
