----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17157/#review34169 -----------------------------------------------------------
Ship it! nit: + // Taking third argument as scaling factor to setting mapred.task.timeout It's no longer the 3rd argument, otherwise looks good. please attach final 1.5+ specific patch to the jira - Sean Busbey On Feb. 9, 2014, 11:23 p.m., Hung Pham wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/17157/ > ----------------------------------------------------------- > > (Updated Feb. 9, 2014, 11:23 p.m.) > > > Review request for accumulo. > > > Bugs: ACCUMULO-2005 > https://issues.apache.org/jira/browse/ACCUMULO-2005 > > > Repository: accumulo > > > Description > ------- > > ACCUMULO-2005: Add a 3rd argument to functional test RunTests.java to allow a > timeout factor for mapred.task.timeout and run.py -f flag > > > Diffs > ----- > > test/src/main/java/org/apache/accumulo/test/functional/RunTests.java > 91ee66e > test/system/auto/README 7d18e8b > > Diff: https://reviews.apache.org/r/17157/diff/ > > > Testing > ------- > > Testing was done on small 5-nodes cluster to ensure MR job complete > successfully instead of failing out due to timeouts that lead to killed > attempts. > > > File Attachments > ---------------- > > ACCUMULO-2005.v7.patch.txt > > https://reviews.apache.org/media/uploaded/files/2014/02/09/4eceb3be-f5a4-487f-84c4-01d3833f5507__ACCUMULO-2005.v7.patch.txt > > > Thanks, > > Hung Pham > >
