> On Feb. 25, 2014, 9:22 p.m., Sean Busbey wrote:
> > src/server/src/main/java/org/apache/accumulo/server/test/continuous/ContinuousIngest.java,
> > lines 153-155
> > <https://reviews.apache.org/r/18444/diff/2/?file=503673#file503673line153>
> >
> > Can we include the table name in the error message? Is it worth logging
> > at FATAL?
>
> Bill Havanki wrote:
> +1
The table name is automatically included in the exception message as part of
the TNFE constructor. When accessing "tableName", this trace will look
something like:
Exception in thread "main"
org.apache.accumulo.core.client.TableNotFoundException: Table tableName does
not exist (Consult the README and create the table before starting test
processes.)
at
org.apache.accumulo.server.test.continuous.ContinuousUtil.createScanner(ContinuousUtil.java:50)
Also, I'd rather not log-and-throw. Rationale:
https://today.java.net/article/2006/04/04/exception-handling-antipatterns#logAndThrow
> On Feb. 25, 2014, 9:22 p.m., Sean Busbey wrote:
> > src/server/src/main/java/org/apache/accumulo/server/test/continuous/ContinuousUtil.java,
> > line 32
> > <https://reviews.apache.org/r/18444/diff/2/?file=503676#file503676line32>
> >
> > nit: trailing whitespace
Will fix before committing.
- Mike
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18444/#review35464
-----------------------------------------------------------
On Feb. 25, 2014, 8:46 p.m., Mike Drob wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18444/
> -----------------------------------------------------------
>
> (Updated Feb. 25, 2014, 8:46 p.m.)
>
>
> Review request for accumulo.
>
>
> Bugs: ACCUMULO-2399
> https://issues.apache.org/jira/browse/ACCUMULO-2399
>
>
> Repository: accumulo
>
>
> Description
> -------
>
> ACCUMULO-2399 Alert user CI table should exist
>
> Extract common table checking functionality for continuous clients and
> fail fast when the table does not exist. No longer create the table in
> ingest to make the requirement explicit.
>
>
> Diffs
> -----
>
>
> src/server/src/main/java/org/apache/accumulo/server/test/continuous/ContinuousBatchWalker.java
> 4659affc49fc7fc2519e092330dda817ccbbadcd
>
> src/server/src/main/java/org/apache/accumulo/server/test/continuous/ContinuousIngest.java
> b63efbc9c7423be8985a292d0c162a672e4b65a0
>
> src/server/src/main/java/org/apache/accumulo/server/test/continuous/ContinuousQuery.java
> c8ae6ecf9e5ef2bd51cb803cba429baaf57f3d6a
>
> src/server/src/main/java/org/apache/accumulo/server/test/continuous/ContinuousScanner.java
> 0ac3df63a260a201544b3623d4901b355d7ea21a
>
> src/server/src/main/java/org/apache/accumulo/server/test/continuous/ContinuousUtil.java
> PRE-CREATION
>
> src/server/src/main/java/org/apache/accumulo/server/test/continuous/ContinuousWalk.java
> 7d1e7f95c7e5a7a172990322e2992e536f2725e3
>
> Diff: https://reviews.apache.org/r/18444/diff/
>
>
> Testing
> -------
>
> Unit tests. Started continuous ingest against a local cluster and it did not
> run.
>
>
> Thanks,
>
> Mike Drob
>
>
