----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18917/#review36568 -----------------------------------------------------------
core/src/main/java/org/apache/accumulo/core/security/ColumnVisibility.java <https://reviews.apache.org/r/18917/#comment67572> Add JavaDoc to inform user's that this will apply DeMorgan's. core/src/main/java/org/apache/accumulo/core/security/ColumnVisibility.java <https://reviews.apache.org/r/18917/#comment67568> This would likely be better as a switch/case. core/src/test/java/org/apache/accumulo/core/security/ColumnVisibilityTest.java <https://reviews.apache.org/r/18917/#comment67570> Can you add a double DeMorgan's test? i.e. start with "(!a|!b)&(!c|!d)" and normalize from there. - Mike Drob On March 7, 2014, 7:41 p.m., Joe Ferner wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/18917/ > ----------------------------------------------------------- > > (Updated March 7, 2014, 7:41 p.m.) > > > Review request for accumulo. > > > Repository: accumulo > > > Description > ------- > > This patch adds a NOT "!" operator to ColumnVisibility. > > The syntax is as follows: > !a > (!a)&(!b) > a&(!b) > a&(!(b|c)) > > Because of the nature of the current visibility parsing algorithm the > additional parentheses are required. > In the shell, the "Unable to render embedded object: File (" requires > escaping. This is due to how JLine parses the command and attempts to > substitute ") not found." with history. > > > Diffs > ----- > > core/src/main/java/org/apache/accumulo/core/security/ColumnVisibility.java > 75091d2 > > core/src/main/java/org/apache/accumulo/core/security/VisibilityEvaluator.java > 725b2c7 > > core/src/test/java/org/apache/accumulo/core/security/ColumnVisibilityTest.java > 7a6a80d > > core/src/test/java/org/apache/accumulo/core/security/VisibilityEvaluatorTest.java > ee4d2ee > > Diff: https://reviews.apache.org/r/18917/diff/ > > > Testing > ------- > > This patch includes unit tests for parsing, flattening, and evaluating the > not operator. > > > Thanks, > > Joe Ferner > >
