----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19189/#review37058 -----------------------------------------------------------
core/src/test/java/org/apache/accumulo/core/iterators/user/BigDecimalCombinerTest.java <https://reviews.apache.org/r/19189/#comment68305> These are actually "keys that aggregate". (This comment, which is copied from CombinerTest, is a bit misleading in that whether or not the keys aggregate depends on the column passed to IteratorSetting.) Otherwise the test looks okay to me. - Billie Rinaldi On March 13, 2014, 1:53 p.m., Mike Drob wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/19189/ > ----------------------------------------------------------- > > (Updated March 13, 2014, 1:53 p.m.) > > > Review request for accumulo. > > > Bugs: ACCUMULO-2465 > https://issues.apache.org/jira/browse/ACCUMULO-2465 > > > Repository: accumulo > > > Description > ------- > > ACCUMULO-2465 Unit tests for BigDecimalCombiner > > Add tests for min and max. Refactor setup into @Before method. > > > Diffs > ----- > > > core/src/test/java/org/apache/accumulo/core/iterators/user/BigDecimalCombinerTest.java > 4cf4d5d65ab8a2705293e547e76b196a7fd7a5a6 > > core/src/test/java/org/apache/accumulo/core/iterators/user/CombinerTest.java > 0c91ef7c266f13a4dc67045de0d7a2a774e985c4 > > Diff: https://reviews.apache.org/r/19189/diff/ > > > Testing > ------- > > Unit tests. > > > Thanks, > > Mike Drob > >
