> On March 14, 2014, 1:29 p.m., kturner wrote: > > examples/simple/src/main/java/org/apache/accumulo/examples/simple/mapreduce/TableToFile.java, > > line 63 > > <https://reviews.apache.org/r/19226/diff/1/?file=519711#file519711line63> > > > > why not use immutable entry here?
My guess is because the old entry implementation does not throw UnsupportedOperationException on setValue calls. - Bill ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19226/#review37224 ----------------------------------------------------------- On March 14, 2014, 1:10 p.m., Mike Drob wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/19226/ > ----------------------------------------------------------- > > (Updated March 14, 2014, 1:10 p.m.) > > > Review request for accumulo. > > > Bugs: ACCUMULO-2477 > https://issues.apache.org/jira/browse/ACCUMULO-2477 > > > Repository: accumulo > > > Description > ------- > > ACCUMULO-2477 Replace our implemenations of Entry > > Most of our uses of Map.Entry can defer to SimpleImmutableEntry. We > should use that instead of maintaining our own version. > > > Diffs > ----- > > > core/src/main/java/org/apache/accumulo/core/client/impl/TabletServerBatchReaderIterator.java > 30e12c1a42327d79dddf183992a1dc397607d407 > core/src/main/java/org/apache/accumulo/core/data/Key.java > 74975aebb3cf1184f984d1325ccb9a02e23a6915 > core/src/main/java/org/apache/accumulo/core/data/KeyValue.java > 83996f86eb99cfa72867053a90f4370c1d41e4d7 > core/src/main/java/org/apache/accumulo/core/util/Pair.java > fb4ad80067cf5ea3a219a6b5876b6ed2f71fa8f3 > > examples/simple/src/main/java/org/apache/accumulo/examples/simple/mapreduce/TableToFile.java > 3a211e2b55052292a7e28ed585c9848a81995a33 > server/tserver/src/main/java/org/apache/accumulo/tserver/NativeMap.java > a454d6c1f3233120fa7af217afe5230542fed0c1 > server/tserver/src/main/java/org/apache/accumulo/tserver/Tablet.java > dd20fd911e8e4bb047a35aec2bc94e5948e8075a > server/tserver/src/main/java/org/apache/accumulo/tserver/TabletServer.java > cdb9dbf015be231358af420a79231082a9566ac0 > > Diff: https://reviews.apache.org/r/19226/diff/ > > > Testing > ------- > > Existing unit tests still pass. > > > Thanks, > > Mike Drob > >
