> On March 19, 2014, 12:52 p.m., Mike Drob wrote: > > core/src/main/java/org/apache/accumulo/core/client/impl/InstanceFactory.java, > > line 27 > > <https://reviews.apache.org/r/19409/diff/1/?file=528072#file528072line27> > > > > Nit: whitespace.
Our code style rules do that. Some sort of bug in Eclipse. I'll trim 'em. > On March 19, 2014, 12:52 p.m., Mike Drob wrote: > > core/src/main/java/org/apache/accumulo/core/client/impl/InstanceFactory.java, > > line 37 > > <https://reviews.apache.org/r/19409/diff/1/?file=528072#file528072line37> > > > > Is this exception class used? If not, it should be removed. It's not, but I wanted to leave a way for future factory implementations to predictably throw exceptions, at the factory level of abstraction (Effective Java 2nd ed. Item 61). > On March 19, 2014, 12:52 p.m., Mike Drob wrote: > > core/src/test/java/org/apache/accumulo/core/client/impl/ZooKeeperInstanceFactoryTest.java, > > line 23 > > <https://reviews.apache.org/r/19409/diff/1/?file=528074#file528074line23> > > > > Please enumerate the imports rather than using wildcards. OK > On March 19, 2014, 12:52 p.m., Mike Drob wrote: > > core/src/test/java/org/apache/accumulo/core/client/impl/ZooKeeperInstanceFactoryTest.java, > > line 33 > > <https://reviews.apache.org/r/19409/diff/1/?file=528074#file528074line33> > > > > createNiceMock takes care of this for you. I'll do it! - Bill ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19409/#review37731 ----------------------------------------------------------- On March 19, 2014, 12:44 p.m., Bill Havanki wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/19409/ > ----------------------------------------------------------- > > (Updated March 19, 2014, 12:44 p.m.) > > > Review request for accumulo. > > > Bugs: ACCUMULO-2497 > https://issues.apache.org/jira/browse/ACCUMULO-2497 > > > Repository: accumulo > > > Description > ------- > > To help in testing, this commit adds an InstanceFactory interface with some > implementations. > > To avoid changing the public API, some classes are in o.a.a.core.client.impl. > > > Diffs > ----- > > > core/src/main/java/org/apache/accumulo/core/client/impl/InstanceFactory.java > PRE-CREATION > > core/src/main/java/org/apache/accumulo/core/client/impl/ZooKeeperInstanceFactory.java > PRE-CREATION > > core/src/test/java/org/apache/accumulo/core/client/impl/ZooKeeperInstanceFactoryTest.java > PRE-CREATION > > server/base/src/main/java/org/apache/accumulo/server/client/HdfsZooInstanceFactory.java > PRE-CREATION > > server/base/src/test/java/org/apache/accumulo/server/client/HdfsZooInstanceFactoryTest.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/19409/diff/ > > > Testing > ------- > > Unit tests pass. > > > Thanks, > > Bill Havanki > >
