> On March 26, 2014, 3:10 p.m., kturner wrote: > > fate/src/main/java/org/apache/accumulo/fate/ReadOnlyStore.java, line 57 > > <https://reviews.apache.org/r/19662/diff/2/?file=536760#file536760line57> > > > > Seems like this can be cast to Repo after return? > > Sean Busbey wrote: > It can. I suppose if you're distrustful enough that you're bothering to > use the decorator that's probably an issue. I could make a similarly > distrustful decorator for Repo that enforces the ReadOnlyRepo interface?
I think a decorator that limits the ability to cast would be a good thing. Makes it much easier to reason about passing a read only store to other code. - kturner ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19662/#review38610 ----------------------------------------------------------- On March 26, 2014, 1:06 a.m., Sean Busbey wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/19662/ > ----------------------------------------------------------- > > (Updated March 26, 2014, 1:06 a.m.) > > > Review request for accumulo and kturner. > > > Bugs: ACCUMULO-2551 > https://issues.apache.org/jira/browse/ACCUMULO-2551 > > > Repository: accumulo > > > Description > ------- > > Per request in #Accumulo, proposed changes to provide read only access > > > Diffs > ----- > > fate/pom.xml 433e61a > fate/src/main/java/org/apache/accumulo/fate/AdminUtil.java 0162466 > fate/src/main/java/org/apache/accumulo/fate/Fate.java 9d24b0b > fate/src/main/java/org/apache/accumulo/fate/ReadOnlyRepo.java PRE-CREATION > fate/src/main/java/org/apache/accumulo/fate/ReadOnlyStore.java PRE-CREATION > fate/src/main/java/org/apache/accumulo/fate/ReadOnlyTStore.java > PRE-CREATION > fate/src/main/java/org/apache/accumulo/fate/Repo.java 8bdca10 > fate/src/main/java/org/apache/accumulo/fate/TStore.java 3554064 > fate/src/test/java/org/apache/accumulo/fate/AgeOffStoreTest.java c212649 > fate/src/test/java/org/apache/accumulo/fate/ReadOnlyStoreTest.java > PRE-CREATION > fate/src/test/java/org/apache/accumulo/fate/SimpleStore.java 3b78131 > server/src/main/java/org/apache/accumulo/server/fate/Admin.java 4a5f0bc > server/src/main/java/org/apache/accumulo/server/master/Master.java 8c4c864 > > Diff: https://reviews.apache.org/r/19662/diff/ > > > Testing > ------- > > existing and new unit tests run > > > Thanks, > > Sean Busbey > >
