----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20087/#review39686 -----------------------------------------------------------
core/src/main/java/org/apache/accumulo/core/util/shell/commands/TraceCommand.java <https://reviews.apache.org/r/20087/#comment72264> Change seems out of scope of the issue, but not a big deal. shell/pom.xml <https://reviews.apache.org/r/20087/#comment72265> No license header. Will fail to build. shell/pom.xml <https://reviews.apache.org/r/20087/#comment72266> Please add a description. shell/pom.xml <https://reviews.apache.org/r/20087/#comment72267> Drop all provided tags. - Christopher Tubbs On April 7, 2014, 11:55 a.m., Mike Drob wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/20087/ > ----------------------------------------------------------- > > (Updated April 7, 2014, 11:55 a.m.) > > > Review request for accumulo and Christopher Tubbs. > > > Bugs: ACCUMULO-1879 > https://issues.apache.org/jira/browse/ACCUMULO-1879 > > > Repository: accumulo > > > Description > ------- > > Move shell into a separate module. > > > Diffs > ----- > > core/pom.xml a89846c239e863b01eaebecde59ab3682969e7e7 > core/src/main/java/org/apache/accumulo/core/client/mock/MockShell.java > > core/src/main/java/org/apache/accumulo/core/util/format/DeleterFormatter.java > > core/src/main/java/org/apache/accumulo/core/util/shell/Shell.java > > core/src/main/java/org/apache/accumulo/core/util/shell/ShellCommandException.java > > core/src/main/java/org/apache/accumulo/core/util/shell/ShellCompletor.java > core/src/main/java/org/apache/accumulo/core/util/shell/ShellExtension.java > core/src/main/java/org/apache/accumulo/core/util/shell/ShellOptions.java > core/src/main/java/org/apache/accumulo/core/util/shell/ShellOptionsJC.java > core/src/main/java/org/apache/accumulo/core/util/shell/ShellUtil.java > core/src/main/java/org/apache/accumulo/core/util/shell/Token.java > > core/src/main/java/org/apache/accumulo/core/util/shell/commands/AboutCommand.java > > > core/src/main/java/org/apache/accumulo/core/util/shell/commands/ActiveCompactionIterator.java > > > core/src/main/java/org/apache/accumulo/core/util/shell/commands/ActiveScanIterator.java > > > core/src/main/java/org/apache/accumulo/core/util/shell/commands/AddAuthsCommand.java > > > core/src/main/java/org/apache/accumulo/core/util/shell/commands/AddSplitsCommand.java > > > core/src/main/java/org/apache/accumulo/core/util/shell/commands/AuthenticateCommand.java > > > core/src/main/java/org/apache/accumulo/core/util/shell/commands/ByeCommand.java > > > core/src/main/java/org/apache/accumulo/core/util/shell/commands/ClasspathCommand.java > > > core/src/main/java/org/apache/accumulo/core/util/shell/commands/ClearCommand.java > > > core/src/main/java/org/apache/accumulo/core/util/shell/commands/CloneTableCommand.java > > > core/src/main/java/org/apache/accumulo/core/util/shell/commands/ClsCommand.java > > > core/src/main/java/org/apache/accumulo/core/util/shell/commands/CompactCommand.java > > > core/src/main/java/org/apache/accumulo/core/util/shell/commands/ConfigCommand.java > > > core/src/main/java/org/apache/accumulo/core/util/shell/commands/ConstraintCommand.java > > > core/src/main/java/org/apache/accumulo/core/util/shell/commands/CreateNamespaceCommand.java > > > core/src/main/java/org/apache/accumulo/core/util/shell/commands/CreateTableCommand.java > > > core/src/main/java/org/apache/accumulo/core/util/shell/commands/CreateUserCommand.java > > > core/src/main/java/org/apache/accumulo/core/util/shell/commands/DUCommand.java > > > core/src/main/java/org/apache/accumulo/core/util/shell/commands/DebugCommand.java > > > core/src/main/java/org/apache/accumulo/core/util/shell/commands/DeleteCommand.java > > > core/src/main/java/org/apache/accumulo/core/util/shell/commands/DeleteIterCommand.java > > > core/src/main/java/org/apache/accumulo/core/util/shell/commands/DeleteManyCommand.java > > > core/src/main/java/org/apache/accumulo/core/util/shell/commands/DeleteNamespaceCommand.java > > > core/src/main/java/org/apache/accumulo/core/util/shell/commands/DeleteRowsCommand.java > > > core/src/main/java/org/apache/accumulo/core/util/shell/commands/DeleteScanIterCommand.java > > > core/src/main/java/org/apache/accumulo/core/util/shell/commands/DeleteShellIterCommand.java > > > core/src/main/java/org/apache/accumulo/core/util/shell/commands/DeleteTableCommand.java > > > core/src/main/java/org/apache/accumulo/core/util/shell/commands/DeleteUserCommand.java > > > core/src/main/java/org/apache/accumulo/core/util/shell/commands/DropTableCommand.java > > > core/src/main/java/org/apache/accumulo/core/util/shell/commands/DropUserCommand.java > > > core/src/main/java/org/apache/accumulo/core/util/shell/commands/EGrepCommand.java > > > core/src/main/java/org/apache/accumulo/core/util/shell/commands/ExecfileCommand.java > > > core/src/main/java/org/apache/accumulo/core/util/shell/commands/ExitCommand.java > > > core/src/main/java/org/apache/accumulo/core/util/shell/commands/ExportTableCommand.java > > > core/src/main/java/org/apache/accumulo/core/util/shell/commands/ExtensionCommand.java > > > core/src/main/java/org/apache/accumulo/core/util/shell/commands/FateCommand.java > > > core/src/main/java/org/apache/accumulo/core/util/shell/commands/FlushCommand.java > > > core/src/main/java/org/apache/accumulo/core/util/shell/commands/FormatterCommand.java > > > core/src/main/java/org/apache/accumulo/core/util/shell/commands/GetAuthsCommand.java > > > core/src/main/java/org/apache/accumulo/core/util/shell/commands/GetGroupsCommand.java > > > core/src/main/java/org/apache/accumulo/core/util/shell/commands/GetSplitsCommand.java > > > core/src/main/java/org/apache/accumulo/core/util/shell/commands/GrantCommand.java > > > core/src/main/java/org/apache/accumulo/core/util/shell/commands/GrepCommand.java > > > core/src/main/java/org/apache/accumulo/core/util/shell/commands/HelpCommand.java > > > core/src/main/java/org/apache/accumulo/core/util/shell/commands/HiddenCommand.java > > > core/src/main/java/org/apache/accumulo/core/util/shell/commands/HistoryCommand.java > > > core/src/main/java/org/apache/accumulo/core/util/shell/commands/ImportDirectoryCommand.java > > > core/src/main/java/org/apache/accumulo/core/util/shell/commands/ImportTableCommand.java > > > core/src/main/java/org/apache/accumulo/core/util/shell/commands/InfoCommand.java > > > core/src/main/java/org/apache/accumulo/core/util/shell/commands/InsertCommand.java > > > core/src/main/java/org/apache/accumulo/core/util/shell/commands/InterpreterCommand.java > > > core/src/main/java/org/apache/accumulo/core/util/shell/commands/ListCompactionsCommand.java > > > core/src/main/java/org/apache/accumulo/core/util/shell/commands/ListIterCommand.java > > > core/src/main/java/org/apache/accumulo/core/util/shell/commands/ListScansCommand.java > > > core/src/main/java/org/apache/accumulo/core/util/shell/commands/ListShellIterCommand.java > > > core/src/main/java/org/apache/accumulo/core/util/shell/commands/MaxRowCommand.java > > > core/src/main/java/org/apache/accumulo/core/util/shell/commands/MergeCommand.java > > > core/src/main/java/org/apache/accumulo/core/util/shell/commands/NamespacePermissionsCommand.java > > > core/src/main/java/org/apache/accumulo/core/util/shell/commands/NamespacesCommand.java > > > core/src/main/java/org/apache/accumulo/core/util/shell/commands/NoTableCommand.java > > > core/src/main/java/org/apache/accumulo/core/util/shell/commands/OfflineCommand.java > > > core/src/main/java/org/apache/accumulo/core/util/shell/commands/OnlineCommand.java > > > core/src/main/java/org/apache/accumulo/core/util/shell/commands/OptUtil.java > > core/src/main/java/org/apache/accumulo/core/util/shell/commands/PasswdCommand.java > > > core/src/main/java/org/apache/accumulo/core/util/shell/commands/PingCommand.java > > > core/src/main/java/org/apache/accumulo/core/util/shell/commands/PingIterator.java > > > core/src/main/java/org/apache/accumulo/core/util/shell/commands/QuestionCommand.java > > > core/src/main/java/org/apache/accumulo/core/util/shell/commands/QuitCommand.java > > > core/src/main/java/org/apache/accumulo/core/util/shell/commands/QuotedStringTokenizer.java > > > core/src/main/java/org/apache/accumulo/core/util/shell/commands/RenameNamespaceCommand.java > > > core/src/main/java/org/apache/accumulo/core/util/shell/commands/RenameTableCommand.java > > > core/src/main/java/org/apache/accumulo/core/util/shell/commands/RevokeCommand.java > > > core/src/main/java/org/apache/accumulo/core/util/shell/commands/ScanCommand.java > > > core/src/main/java/org/apache/accumulo/core/util/shell/commands/ScriptCommand.java > > > core/src/main/java/org/apache/accumulo/core/util/shell/commands/SetAuthsCommand.java > > > core/src/main/java/org/apache/accumulo/core/util/shell/commands/SetGroupsCommand.java > > > core/src/main/java/org/apache/accumulo/core/util/shell/commands/SetIterCommand.java > > > core/src/main/java/org/apache/accumulo/core/util/shell/commands/SetScanIterCommand.java > > > core/src/main/java/org/apache/accumulo/core/util/shell/commands/SetShellIterCommand.java > > > core/src/main/java/org/apache/accumulo/core/util/shell/commands/ShellPluginConfigurationCommand.java > > > core/src/main/java/org/apache/accumulo/core/util/shell/commands/SleepCommand.java > > > core/src/main/java/org/apache/accumulo/core/util/shell/commands/SystemPermissionsCommand.java > > > core/src/main/java/org/apache/accumulo/core/util/shell/commands/TableCommand.java > > > core/src/main/java/org/apache/accumulo/core/util/shell/commands/TableOperation.java > > > core/src/main/java/org/apache/accumulo/core/util/shell/commands/TablePermissionsCommand.java > > > core/src/main/java/org/apache/accumulo/core/util/shell/commands/TablesCommand.java > > > core/src/main/java/org/apache/accumulo/core/util/shell/commands/TraceCommand.java > 281a33ac6722320f44d42ccb141445205dc0abd4 > > core/src/main/java/org/apache/accumulo/core/util/shell/commands/UserCommand.java > > > core/src/main/java/org/apache/accumulo/core/util/shell/commands/UserPermissionsCommand.java > > > core/src/main/java/org/apache/accumulo/core/util/shell/commands/UsersCommand.java > > > core/src/main/java/org/apache/accumulo/core/util/shell/commands/WhoAmICommand.java > > > core/src/test/java/org/apache/accumulo/core/util/format/DeleterFormatterTest.java > > > core/src/test/java/org/apache/accumulo/core/util/shell/PasswordConverterTest.java > > core/src/test/java/org/apache/accumulo/core/util/shell/ShellConfigTest.java > > > core/src/test/java/org/apache/accumulo/core/util/shell/ShellSetInstanceTest.java > > core/src/test/java/org/apache/accumulo/core/util/shell/ShellTest.java > core/src/test/java/org/apache/accumulo/core/util/shell/ShellUtilTest.java > > core/src/test/java/org/apache/accumulo/core/util/shell/command/FormatterCommandTest.java > > core/src/test/resources/shelltest.txt > examples/simple/pom.xml 752d952978903f890ac41a0aefcbcdf77560e2fe > pom.xml a829ba37e75c9d0ad7d3ec620ca92268dfee00ff > server/monitor/pom.xml 10586f12d21f6ac573cc3930e0de62abd8417e46 > shell/pom.xml PRE-CREATION > shell/src/test/resources/log4j.properties PRE-CREATION > > Diff: https://reviews.apache.org/r/20087/diff/ > > > Testing > ------- > > > Thanks, > > Mike Drob > >
