-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20177/
-----------------------------------------------------------
Review request for accumulo.
Bugs: ACCUMULO-2212
https://issues.apache.org/jira/browse/ACCUMULO-2212
Repository: accumulo
Description
-------
The o.a.a.server.zookeeper.ZooReaderWriter class is mostly copied into a new
ZooReaderWriterFactory class. Users of the factory can work directly with FATE
ZooReaderWriter instances, instead of those of the server type, which is no
longer needed. The logic for building instances from site configuration data is
in the factory.
As part of this change, the invocation handler used to retry ZK calls on
connection loss is refactored into a new RetryingInvocationHandler.
Diffs
-----
fate/src/main/java/org/apache/accumulo/fate/zookeeper/RetryingInvocationHandler.java
PRE-CREATION
fate/src/main/java/org/apache/accumulo/fate/zookeeper/ZooReaderWriter.java
2a327b0
fate/src/test/java/org/apache/accumulo/fate/zookeeper/RetryingInvocationHandlerTest.java
PRE-CREATION
server/base/src/main/java/org/apache/accumulo/server/zookeeper/ZooReaderWriterFactory.java
PRE-CREATION
Diff: https://reviews.apache.org/r/20177/diff/
Testing
-------
Unit tests pass; functional tests in progress, but passed in prior, more
wide-ranging version.
Thanks,
Bill Havanki
