----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20180/#review40448 -----------------------------------------------------------
test/system/auto/simple/recoverWithEmpty.py <https://reviews.apache.org/r/20180/#comment73466> If this file exist but it not referenced in the metadata table, then this test will not properly validate what its trying to... maybe the test should look in the metadata table to get the filename, or to just verify metadata refs the file - kturner On April 15, 2014, 7:38 p.m., Sean Busbey wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/20180/ > ----------------------------------------------------------- > > (Updated April 15, 2014, 7:38 p.m.) > > > Review request for accumulo and Josh Elser. > > > Bugs: ACCUMULO-2654 > https://issues.apache.org/jira/browse/ACCUMULO-2654 > > > Repository: accumulo > > > Description > ------- > > Adds a simple utility for creating an empty RFile, leveraging existing code. > > > Diffs > ----- > > src/core/src/main/java/org/apache/accumulo/core/file/rfile/CreateEmpty.java > PRE-CREATION > > src/core/src/main/java/org/apache/accumulo/core/file/rfile/RFileOperations.java > 5374332 > test/system/auto/simple/recoverWithEmpty.py PRE-CREATION > > Diff: https://reviews.apache.org/r/20180/diff/ > > > Testing > ------- > > tested basic error handling and help messages. tested creating file on hdfs > and local file system. tested default codec, gz, and specifying the same > codec as default. Used PrintInfo to verify generated files. > > ran new functional test. > > > Thanks, > > Sean Busbey > >
