> On April 16, 2014, 6:17 p.m., Mike Drob wrote: > > docs/src/main/resources/RB.md, line 65 > > <https://reviews.apache.org/r/20422/diff/1/?file=561011#file561011line65> > > > > Might need a step for contributors to still upload the patch to JIRA, > > using 'git format-patch' etc... as outlined in [some other document]. I'm > > never sure if I can apply the review diff directly and if it preserves > > author and commit message. > > Sean Busbey wrote: > if the patch uploaded was made with format-patch, RB will maintain it. > (compare https://reviews.apache.org/r/20180/ and > https://reviews.apache.org/r/20419/ ) > > Mike Drob wrote: > If the patch was made using 'rbt' or 'post-review' then it will be just a > diff, and not a full patch. I anticipate those to be the more common use > case, simply from a usability standpoint. > > Clarification in the document would be helpful, probably using "may need" > instead of RFC Must.
the current text only makes mention of posting patch files, with nothing about rbt or post-review existing. I agree we should probably be steering people in that direction though. Maybe something like: ---- * Once you've closed the issue as submitted, please attach the final version of your changes as a patch containing a single commit [per the final steps of the contribution process][contributor] [contributor]: http://accumulo.apache.org/git.html#contributors ---- Having a single path for contributors to take is probably a net good, rather than having instructions based on however they got the patch into RB. - Sean ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20422/#review40581 ----------------------------------------------------------- On April 16, 2014, 5:57 p.m., Bill Havanki wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/20422/ > ----------------------------------------------------------- > > (Updated April 16, 2014, 5:57 p.m.) > > > Review request for accumulo. > > > Bugs: ACCUMULO-1834 > https://issues.apache.org/jira/browse/ACCUMULO-1834 > > > Repository: accumulo > > > Description > ------- > > A proposed set of guidelines for using Review Board, in deference to our > recently-approved and improved bylaws. > > > Diffs > ----- > > docs/src/main/resources/RB.md PRE-CREATION > > Diff: https://reviews.apache.org/r/20422/diff/ > > > Testing > ------- > > > Thanks, > > Bill Havanki > >
