> On April 21, 2014, 6:27 p.m., Sean Busbey wrote: > > core/src/main/java/org/apache/accumulo/core/cli/ClientOnRequiredTable.java, > > lines 29-48 > > <https://reviews.apache.org/r/20524/diff/1/?file=563182#file563182line29> > > > > why the get/set when this param is public?
Should not have been public. > On April 21, 2014, 6:27 p.m., Sean Busbey wrote: > > core/src/main/java/org/apache/accumulo/core/cli/MapReduceClientOnDefaultTable.java, > > lines 27-40 > > <https://reviews.apache.org/r/20524/diff/1/?file=563184#file563184line27> > > > > I believe you can do this by setting tableName to the default table. > > > > This will also let jcommander give the default in help text. I'll have to play around with this to see if I can set that properly. > On April 21, 2014, 6:27 p.m., Sean Busbey wrote: > > core/src/main/java/org/apache/accumulo/core/cli/MapReduceClientOnRequiredTable.java, > > lines 49-52 > > <https://reviews.apache.org/r/20524/diff/1/?file=563185#file563185line49> > > > > no reason to use a method instead of the field directly. Field should have been private. - Mike ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20524/#review40906 ----------------------------------------------------------- On April 21, 2014, 5:44 p.m., Mike Drob wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/20524/ > ----------------------------------------------------------- > > (Updated April 21, 2014, 5:44 p.m.) > > > Review request for accumulo and Sean Busbey. > > > Bugs: ACCUMULO-2702 > https://issues.apache.org/jira/browse/ACCUMULO-2702 > > > Repository: accumulo > > > Description > ------- > > ACCUMULO-2702 Create separate MR Client Opts > > Separate the MR opts from the core client opts. There is plenty more > work to be done, but this is a reasonable first step in that direction. > > We should probably be using a lot more composition than inheritance > overall, and this resulted in some slight code duplication, but the > change set would have been *much* more extensive otherwise. > > > Diffs > ----- > > core/src/main/java/org/apache/accumulo/core/cli/ClientOnDefaultTable.java > b86638a2e73e03c46ce125dc82f32ad9f3c4daeb > core/src/main/java/org/apache/accumulo/core/cli/ClientOnRequiredTable.java > a4513157cfa3834e97eae79071a60a135a1a94c1 > core/src/main/java/org/apache/accumulo/core/cli/ClientOpts.java > d209d3feb798c593dc83353f1ceb032925b90656 > > core/src/main/java/org/apache/accumulo/core/cli/MapReduceClientOnDefaultTable.java > PRE-CREATION > > core/src/main/java/org/apache/accumulo/core/cli/MapReduceClientOnRequiredTable.java > PRE-CREATION > core/src/main/java/org/apache/accumulo/core/cli/MapReduceClientOpts.java > PRE-CREATION > core/src/main/java/org/apache/accumulo/core/util/Merge.java > 4c0a3ea497b5b25a18d1cb808b675b7bb6103e5a > > examples/simple/src/main/java/org/apache/accumulo/examples/simple/client/Flush.java > 225fac241b3bfe25f12b441255b91856536b7467 > > examples/simple/src/main/java/org/apache/accumulo/examples/simple/client/RandomBatchScanner.java > 5fe23a5a65fc13b8be6852848cd11a11ebe4290b > > examples/simple/src/main/java/org/apache/accumulo/examples/simple/client/RandomBatchWriter.java > 44947d16f9b95d148028067821f1d3d05ee6c4df > > examples/simple/src/main/java/org/apache/accumulo/examples/simple/client/SequentialBatchWriter.java > c37c1c3ffbbe08a09ab9a8f8113cb83bdb03fa50 > > examples/simple/src/main/java/org/apache/accumulo/examples/simple/dirlist/FileCount.java > a810b3853dc6ab2746e4638222d117deb8fcc638 > > examples/simple/src/main/java/org/apache/accumulo/examples/simple/dirlist/QueryUtil.java > 7795ec338779644c0808ae4f81dec7bd4ea73b0b > > examples/simple/src/main/java/org/apache/accumulo/examples/simple/filedata/CharacterHistogram.java > d0662b62c38305278dd752e65c0a7b32020cf1d1 > > examples/simple/src/main/java/org/apache/accumulo/examples/simple/filedata/FileDataIngest.java > 78fef0de56db988d39c170e5e7e64206c97c6214 > > examples/simple/src/main/java/org/apache/accumulo/examples/simple/helloworld/InsertWithBatchWriter.java > b980133c0f2830ad463228b7848111d362cd8233 > > examples/simple/src/main/java/org/apache/accumulo/examples/simple/helloworld/ReadData.java > 97bb6332b5101cd77a8fada9c842d8ff109b6d7e > > examples/simple/src/main/java/org/apache/accumulo/examples/simple/isolation/InterferenceTest.java > a90848edfa034ecedac0c51e10188d30b61382c5 > > examples/simple/src/main/java/org/apache/accumulo/examples/simple/mapreduce/NGramIngest.java > f8d0b0b6d244038daeb01dedce25a65cd20a1745 > > examples/simple/src/main/java/org/apache/accumulo/examples/simple/mapreduce/RegexExample.java > 47e587926a49792d47fb94aa2fb91fe81264b4c9 > > examples/simple/src/main/java/org/apache/accumulo/examples/simple/mapreduce/RowHash.java > 1fa9b8f21239b81a3716080023e246f2450fbe0b > > examples/simple/src/main/java/org/apache/accumulo/examples/simple/mapreduce/TableToFile.java > 094e6c1c5e4f529df1acfef5f8324b3e746ce911 > > examples/simple/src/main/java/org/apache/accumulo/examples/simple/mapreduce/TeraSortIngest.java > f9f2d393b2df75abe095128abe4babf3813965ab > > examples/simple/src/main/java/org/apache/accumulo/examples/simple/mapreduce/UniqueColumns.java > e0e29ce8ed1669190c89497ce619c3a0d8076fd7 > > examples/simple/src/main/java/org/apache/accumulo/examples/simple/mapreduce/WordCount.java > 220b85cecca972051ccd25135fc79eaecdd3e87f > > examples/simple/src/main/java/org/apache/accumulo/examples/simple/mapreduce/bulk/BulkIngestExample.java > 72bd7eb95ac7648234e993b28b876f6c5a61ea89 > > examples/simple/src/main/java/org/apache/accumulo/examples/simple/mapreduce/bulk/SetupTable.java > b6d3d139904896aa2ada5f6ba9831e15cca79247 > > examples/simple/src/main/java/org/apache/accumulo/examples/simple/mapreduce/bulk/VerifyIngest.java > 4366416f7886f9395b2db8787a51f80074fe6d4a > > examples/simple/src/main/java/org/apache/accumulo/examples/simple/shard/Index.java > 47310612c4ff05c5ad15eeb270881d0a8c1e77da > > examples/simple/src/main/java/org/apache/accumulo/examples/simple/shard/Query.java > aa12c712fd4b5b96388f5449767890e59d7a6871 > > examples/simple/src/test/java/org/apache/accumulo/examples/simple/dirlist/CountTest.java > b32918ecc43cca4aacbdbd0bc36b9a974bb598a2 > test/src/main/java/org/apache/accumulo/test/BulkImportDirectory.java > 42a80410e81760afcc0cbe22112414122389ce3c > test/src/main/java/org/apache/accumulo/test/TestBinaryRows.java > c2af60ce0c50cd0f2b8d43b1834b56457cea891e > > test/src/main/java/org/apache/accumulo/test/continuous/ContinuousIngest.java > 2aca57950dbb56350e02a910b5d0eb28063daec1 > > test/src/main/java/org/apache/accumulo/test/continuous/ContinuousStatsCollector.java > f8cb0a8a50f46e8ff5444705eeb22abb62301144 > > test/src/main/java/org/apache/accumulo/test/continuous/ContinuousVerify.java > d56ccde4b4ebee4a06b081c27d2b56c49593018a > > test/src/main/java/org/apache/accumulo/test/performance/scan/CollectTabletStats.java > d2c8d0fab774be791cb3f1cb7e50ef1ad0225f5f > test/src/main/java/org/apache/accumulo/test/randomwalk/bulk/Verify.java > c36e4a0e461ecf5cb7fb798c7f08b7b47ad54350 > test/src/test/java/org/apache/accumulo/test/functional/BinaryIT.java > e6c73c201ddcbe510d2f011f668df77fe4b79a77 > test/src/test/java/org/apache/accumulo/test/functional/BulkIT.java > 831dcd401a15a350318e81451498e0435fb424d1 > > test/src/test/java/org/apache/accumulo/test/functional/FateStarvationIT.java > 4d75a16f39e1debd3ed8821733af2117120b6133 > > test/src/test/java/org/apache/accumulo/test/functional/MasterFailoverIT.java > 218d65eb5fca7206f1e9c4e4fcebda8bd8f29771 > test/src/test/java/org/apache/accumulo/test/functional/RenameIT.java > 8cbe84fac053f07acc17eae8894927de5edad5e7 > test/src/test/java/org/apache/accumulo/test/functional/TableIT.java > 832ec60ac2f4d4c6c8e8f0e6db57b14d3d883aab > test/src/test/java/org/apache/accumulo/test/functional/WriteLotsIT.java > 214fc2fa1451a42712e91a8eaa010015568d8ee0 > > Diff: https://reviews.apache.org/r/20524/diff/ > > > Testing > ------- > > mvn clean verify -P sunny > > > Thanks, > > Mike Drob > >
