> On April 21, 2014, 6:20 p.m., Mike Drob wrote: > > src/server/src/main/java/org/apache/accumulo/server/master/balancer/DefaultLoadBalancer.java, > > line 317 > > <https://reviews.apache.org/r/20525/diff/1/?file=563229#file563229line317> > > > > Can this cause a lot of unnecessary logs? > > Sean Busbey wrote: > When migrations are moving slowly for some reason, it would produce a > message every ~5 seconds. the monitor would roll them up into a single > message, but the log4j would have no such dampening. I could put in a time > threshold, if you'd prefer to keep that down. > > Sean Busbey wrote: > in the case of ACCUMULO-2694, that's a max of 60 messages before self > correction. That seems excessive. once a minute sound better?
Take a look at the change and let me know if this sounds sufficiently fixed? It'll only message if balance calls fail for one contiguous minute, and only repeat the message once per minute. - Sean ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20525/#review40907 ----------------------------------------------------------- On April 21, 2014, 9:32 p.m., Sean Busbey wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/20525/ > ----------------------------------------------------------- > > (Updated April 21, 2014, 9:32 p.m.) > > > Review request for accumulo, Eric Newton and Mike Drob. > > > Bugs: ACCUMULO-2694 > https://issues.apache.org/jira/browse/ACCUMULO-2694 > > > Repository: accumulo > > > Description > ------- > > ACCUMULO-2694 Fix handling of tablet migrations for offline tables. > > * Adds a funtional test that fails due to not rebalancing > * Fix master to clear migrations when it learns that a table has gone > offline > * Update master to periodically clean up migrations for offline tables > * Fix balancers to make sure they log if they can't balance. > > > Diffs > ----- > > src/server/pom.xml dbe4fb4 > src/server/src/main/java/org/apache/accumulo/server/master/Master.java > fb7be51 > > src/server/src/main/java/org/apache/accumulo/server/master/balancer/ChaoticLoadBalancer.java > 02a4e89 > > src/server/src/main/java/org/apache/accumulo/server/master/balancer/DefaultLoadBalancer.java > 4826097 > > src/server/src/main/java/org/apache/accumulo/server/master/balancer/TabletBalancer.java > ad62360 > test/system/auto/stress/migrations.py d07d7a8 > > Diff: https://reviews.apache.org/r/20525/diff/ > > > Testing > ------- > > Ran functional test without other changes -> failed. After full patch > functional test passes. > > > Thanks, > > Sean Busbey > >
