----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21105/#review42305 -----------------------------------------------------------
See my -1 on the ticket. In summary: the rat check already ignores maven build directories, and there is additional risk by introducing additional, unnecessary ignores. - Christopher Tubbs On May 6, 2014, 3:28 a.m., Sean Busbey wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/21105/ > ----------------------------------------------------------- > > (Updated May 6, 2014, 3:28 a.m.) > > > Review request for accumulo and Christopher Tubbs. > > > Bugs: ACCUMULO-2776 > https://issues.apache.org/jira/browse/ACCUMULO-2776 > > > Repository: accumulo > > > Description > ------- > > adds an exclusion for target directories to the rat plugin configs > > > Diffs > ----- > > pom.xml 5f1d20f > server/pom.xml bd61fe6 > > Diff: https://reviews.apache.org/r/21105/diff/ > > > Testing > ------- > > run mvn package, verify that org.apache.rat:apache-rat-plugin:check fails. > > apply change, verify target directories still present, verify that > org.apache.rat:apache-rat-plugin:check passes. > > > Thanks, > > Sean Busbey > >
