> On May 9, 2014, 9:22 p.m., Mike Drob wrote: > > core/src/main/java/org/apache/accumulo/core/client/mapreduce/lib/impl/InputConfigurator.java, > > line 180 > > <https://reviews.apache.org/r/21282/diff/1/?file=577504#file577504line180> > > > > Need to specify UTF8? > > Sean Busbey wrote: > the library always does UTF8. Or do you mean in the docs? > > Mike Drob wrote: > I meant in the String constructor. We explicitly specify UTF-8 elswhere.
There's no String constructor now. That was an error in the version I replaced. - Sean ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21282/#review42605 ----------------------------------------------------------- On May 9, 2014, 11:39 p.m., Sean Busbey wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/21282/ > ----------------------------------------------------------- > > (Updated May 9, 2014, 11:39 p.m.) > > > Review request for accumulo. > > > Bugs: ACCUMULO-2791 > https://issues.apache.org/jira/browse/ACCUMULO-2791 > > > Repository: accumulo > > > Description > ------- > > ACCUMULO-2791 Downgrade commons-codec to match that provided by Hadoop. > > * Povide a core.util Base64 class to enforce the non-chunked behavior we > rely on > * Changed to use codec 1.4 'shaHex' method > > > Diffs > ----- > > > core/src/main/java/org/apache/accumulo/core/client/mapreduce/RangeInputSplit.java > 47b34e9d682518de33a2fe3a8ac2f1ab2fbeae47 > > core/src/main/java/org/apache/accumulo/core/client/mapreduce/lib/impl/ConfiguratorBase.java > 33ca5d2cc5915df0ed6afc88e02d5426a16a0658 > > core/src/main/java/org/apache/accumulo/core/client/mapreduce/lib/impl/InputConfigurator.java > 2fc606c919da120b70df8b524a6d733cd1c011c9 > > core/src/main/java/org/apache/accumulo/core/client/mapreduce/lib/partition/RangePartitioner.java > 54730efa532453d693fa09f641eef8b5fac7b812 > > core/src/main/java/org/apache/accumulo/core/iterators/user/IntersectingIterator.java > c219b5ada99095f523b154da1edfcc4f89249210 > core/src/main/java/org/apache/accumulo/core/security/Authorizations.java > ab3ea6855124ec85b30328ecdc5d3836cce11f63 > core/src/main/java/org/apache/accumulo/core/security/Credentials.java > 9f8b1bef2e0883f0f020506659fdf5c5fec1bfe6 > core/src/main/java/org/apache/accumulo/core/util/Base64.java PRE-CREATION > core/src/main/java/org/apache/accumulo/core/util/CreateToken.java > cc6762a35f652fa0c06dae554bfd34f2afc0ca49 > core/src/main/java/org/apache/accumulo/core/util/Encoding.java > 451d4d65c15de319072982cd4a79ae2909b2d948 > > core/src/main/java/org/apache/accumulo/core/util/shell/commands/AddSplitsCommand.java > 6bd260c7afd0a7890abeafeb4b77b7f95fcdd36a > > core/src/main/java/org/apache/accumulo/core/util/shell/commands/CreateTableCommand.java > 25b92bea9e70a2fe5e7287cd286e02633ed7a75c > > core/src/main/java/org/apache/accumulo/core/util/shell/commands/GetSplitsCommand.java > a27fa4721f471158ef2e6faca5cce8437ae168c1 > > core/src/main/java/org/apache/accumulo/core/util/shell/commands/HiddenCommand.java > c212c751743170aa890ac670b2bf071e3796af4a > > core/src/test/java/org/apache/accumulo/core/client/mapred/AccumuloInputFormatTest.java > 13490e046d4def2d5e74548e07046e7d7c0bb7dc > > core/src/test/java/org/apache/accumulo/core/client/mapreduce/AccumuloInputFormatTest.java > 25009722dc3ac61585caf09f22d812612b873377 > > core/src/test/java/org/apache/accumulo/core/client/mapreduce/lib/impl/ConfiguratorBaseTest.java > 1983470d2fb1657af1df429b5dedc7100ae62d2f > > examples/simple/src/main/java/org/apache/accumulo/examples/simple/mapreduce/RowHash.java > 1fa9b8f21239b81a3716080023e246f2450fbe0b > > examples/simple/src/main/java/org/apache/accumulo/examples/simple/mapreduce/bulk/BulkIngestExample.java > 72bd7eb95ac7648234e993b28b876f6c5a61ea89 > pom.xml 96affb5e15dc60fde48dc042e03c8dec4b335474 > server/base/src/main/java/org/apache/accumulo/server/fs/VolumeUtil.java > 34abb01fcd61d1fcca1a42c8670284e82cd46080 > > server/base/src/main/java/org/apache/accumulo/server/master/state/TabletStateChangeIterator.java > 574952339c7183825c7b0560aabed3883f06cd11 > > server/base/src/main/java/org/apache/accumulo/server/security/SystemCredentials.java > b5d7aba6de6f8ce711201cf8d1e18f551c8da056 > > server/base/src/main/java/org/apache/accumulo/server/util/DumpZookeeper.java > 30aa2eb3e5db385777271deda8ca09e6f01163b9 > > server/base/src/main/java/org/apache/accumulo/server/util/RestoreZookeeper.java > 37ef5f1d00210185bc2b899a68bc32d00c85b35b > server/master/src/main/java/org/apache/accumulo/master/tableOps/Utils.java > 577f5d516e29270b71099ef0fcf309a5ec36034c > > server/monitor/src/main/java/org/apache/accumulo/monitor/servlets/TServersServlet.java > 9f1bd1fc11437d9d0e61d4e303ad376f5fd0a1e8 > > test/src/main/java/org/apache/accumulo/test/randomwalk/shard/BulkInsert.java > 41acce2575de571fd48fdf5759455be3c5698e33 > test/src/test/java/org/apache/accumulo/test/functional/CredentialsIT.java > a35a19af152fc7d6406da3aeea429f1909a4590a > > Diff: https://reviews.apache.org/r/21282/diff/ > > > Testing > ------- > > unit tests passed. full ITs passed. manual cluster tests in progress. > > > Thanks, > > Sean Busbey > >
