> On May 16, 2014, 7:11 p.m., Mike Drob wrote: > > server/tserver/src/main/java/org/apache/accumulo/tserver/log/DfsLogger.java, > > line 150 > > <https://reviews.apache.org/r/21557/diff/1/?file=583591#file583591line150> > > > > Should explicitly handle InvocationTargetException. Can be done in a > > follow-on issue.
I think it would be cleaner to handle this in another issue. I took a wack at it, because I thought it would be a 2 line change. However getCause() returns a Throwable and all of the plumbing for getting the exception back takes Exception. So a bit more would need to be changed. - kturner ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21557/#review43239 ----------------------------------------------------------- On May 16, 2014, 10:56 p.m., kturner wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/21557/ > ----------------------------------------------------------- > > (Updated May 16, 2014, 10:56 p.m.) > > > Review request for accumulo. > > > Bugs: ACCUMULO-2766 > https://issues.apache.org/jira/browse/ACCUMULO-2766 > > > Repository: accumulo > > > Description > ------- > > A possible fix for ACCUMULO-2766. > > > Diffs > ----- > > server/tserver/src/main/java/org/apache/accumulo/tserver/log/DfsLogger.java > eb04f09 > > Diff: https://reviews.apache.org/r/21557/diff/ > > > Testing > ------- > > Only performance testing so far. This patch dramatically improves > performance. > > > Thanks, > > kturner > >
