----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22437/#review45373 -----------------------------------------------------------
Ship it! Ship It! - kturner On June 10, 2014, 8:12 p.m., Bill Havanki wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/22437/ > ----------------------------------------------------------- > > (Updated June 10, 2014, 8:12 p.m.) > > > Review request for accumulo. > > > Bugs: ACCUMULO-2887 > https://issues.apache.org/jira/browse/ACCUMULO-2887 > > > Repository: accumulo > > > Description > ------- > > The logic for maintaining and notifying observers in NamespaceConfiguration > and TableConfiguration is refactored into a new ObservableConfiguration class. > > > Diffs > ----- > > > core/src/main/java/org/apache/accumulo/core/conf/ObservableConfiguration.java > PRE-CREATION > > core/src/test/java/org/apache/accumulo/core/conf/ObservableConfigurationTest.java > PRE-CREATION > > server/base/src/main/java/org/apache/accumulo/server/conf/NamespaceConfWatcher.java > 7f3d73e > > server/base/src/main/java/org/apache/accumulo/server/conf/NamespaceConfiguration.java > eab198e > > server/base/src/main/java/org/apache/accumulo/server/conf/TableConfWatcher.java > c407309 > > server/base/src/main/java/org/apache/accumulo/server/conf/TableConfiguration.java > 909b450 > > Diff: https://reviews.apache.org/r/22437/diff/ > > > Testing > ------- > > Unit tests pass, including the new ObservableConfigurationTest. I was unable > to add observer testing for the refactored classes, but that will arrive late > (probably under ACCUMULO-2615). > > > Thanks, > > Bill Havanki > >
