> On June 23, 2014, 4:41 p.m., kturner wrote: > > core/src/main/java/org/apache/accumulo/core/iterators/system/HeapIterator.java, > > line 53 > > <https://reviews.apache.org/r/22537/diff/1-2/?file=608354#file608354line53> > > > > Was any performance testing done using this different heap > > impelementation? I suspect it will not matter, but it would be nice to > > verify that since the primary purpose of this issue is to improve > > performance.
Tests are now complete. The results are posted on the JIRA ticket. The test harness you created was very convenient for running the tests. > On June 23, 2014, 4:41 p.m., kturner wrote: > > core/src/test/java/org/apache/accumulo/core/iterators/system/BenchmarkMultiIterator.java, > > line 1 > > <https://reviews.apache.org/r/22537/diff/3/?file=615073#file615073line1> > > > > This file has no license (go rat check). I am thinking this file > > should not be be included in the patch, as nothing will run it. Could just > > attach the test to the issue. > > > > If its going to be included, a few sentences of documentation would be > > nice describing why it exist and what it does (or just ref the issue). > > Something like "measuer performance of MultiIterator reading from multiple > > sources w/ interleaved data". Nice catch. I separated it from the patch and also added the documentation. The java file itself was uploaded separately on the JIRA ticket. - Jonathan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22537/#review46408 ----------------------------------------------------------- On June 23, 2014, 4:24 p.m., Jonathan Park wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/22537/ > ----------------------------------------------------------- > > (Updated June 23, 2014, 4:24 p.m.) > > > Review request for accumulo. > > > Bugs: ACCUMULO-2827 > https://issues.apache.org/jira/browse/ACCUMULO-2827 > > > Repository: accumulo > > > Description > ------- > > HeapIterator optimization to avoid always re-inserting back into the heap. > > > Diffs > ----- > > > core/src/main/java/org/apache/accumulo/core/iterators/system/HeapIterator.java > e54f37c > > core/src/test/java/org/apache/accumulo/core/iterators/system/BenchmarkMultiIterator.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/22537/diff/ > > > Testing > ------- > > mvn clean install > > accumulo continuous ingest: saw ~5% improvement on uniformly distributed > data. (see ticket for more details) > > > Thanks, > > Jonathan Park > >
