-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22658/
-----------------------------------------------------------
(Updated June 27, 2014, 5:41 p.m.)
Review request for accumulo.
Changes
-------
Incorporating feedback from reviews.
- Moved Writer into a server-only class
- Re-using BatchWriterImpl instead of rolling our own batching code
Bugs: ACCUMULO-2889
https://issues.apache.org/jira/browse/ACCUMULO-2889
Repository: accumulo
Description
-------
Added additional methods to the Writer class to handle batching.
Potential risks are that we're now holding onto the locks for a bit longer than
we used to. All tablets present in a batch will have their logLock's locked
until the batch is complete.
Diffs (updated)
-----
core/src/main/java/org/apache/accumulo/core/client/impl/Writer.java d6762e7
server/base/src/main/java/org/apache/accumulo/server/util/InternalBatchWriter.java
PRE-CREATION
server/base/src/main/java/org/apache/accumulo/server/util/MetadataTableUtil.java
374017d
server/tserver/src/main/java/org/apache/accumulo/tserver/Tablet.java 36b2289
server/tserver/src/main/java/org/apache/accumulo/tserver/TabletServer.java
57415bd
server/tserver/src/main/java/org/apache/accumulo/tserver/log/TabletServerLogger.java
d25ee75
test/src/test/java/org/apache/accumulo/server/util/InternalBatchWriterIT.java
PRE-CREATION
test/src/test/java/org/apache/accumulo/test/BatchMetadataUpdatesIT.java
PRE-CREATION
Diff: https://reviews.apache.org/r/22658/diff/
Testing
-------
Added a new IT.
We insert a few entries to tablets and ensure that the relevant entries appear
in the WAL and Metadata Table.
One test case that isn't included yet is verifying that root + metadata table
entries are entered correctly.
Thanks,
Jonathan Park
