----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23397/#review47585 -----------------------------------------------------------
I don't see a check to ensure that the MAC isn't getting started against an existing instance while that instance is still running. Can you please add one? Something similar to what the offline tools use should suffice. core/src/main/java/org/apache/accumulo/core/conf/SiteConfiguration.java <https://reviews.apache.org/r/23397/#comment83652> add a javadoc please. minicluster/src/main/java/org/apache/accumulo/minicluster/MiniAccumuloConfig.java <https://reviews.apache.org/r/23397/#comment83653> nit: whitesapce minicluster/src/main/java/org/apache/accumulo/minicluster/MiniAccumuloConfig.java <https://reviews.apache.org/r/23397/#comment83654> nit whitespace minicluster/src/main/java/org/apache/accumulo/minicluster/impl/MiniAccumuloClusterImpl.java <https://reviews.apache.org/r/23397/#comment83656> nit: can we skip this change in line wrapping? I think this change set is already likely to conflict with ACCUMULO-2944 and I'd like to minimize it. minicluster/src/main/java/org/apache/accumulo/minicluster/impl/MiniAccumuloClusterImpl.java <https://reviews.apache.org/r/23397/#comment83657> nit: can we skip this line wrap change? I'm pretty sure this is going to conflict with ACCUMULO-2944 and I'd like to minimize it. minicluster/src/main/java/org/apache/accumulo/minicluster/impl/MiniAccumuloConfigImpl.java <https://reviews.apache.org/r/23397/#comment83658> nit: whitespace minicluster/src/main/java/org/apache/accumulo/minicluster/impl/MiniAccumuloConfigImpl.java <https://reviews.apache.org/r/23397/#comment83659> nit: whitespace minicluster/src/main/java/org/apache/accumulo/minicluster/impl/MiniAccumuloConfigImpl.java <https://reviews.apache.org/r/23397/#comment83660> nit: whitespace minicluster/src/main/java/org/apache/accumulo/minicluster/impl/MiniAccumuloConfigImpl.java <https://reviews.apache.org/r/23397/#comment83661> nit: whitespace minicluster/src/main/java/org/apache/accumulo/minicluster/impl/MiniAccumuloConfigImpl.java <https://reviews.apache.org/r/23397/#comment83662> nit: whitespace - Sean Busbey On July 10, 2014, 5:24 p.m., John Vines wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/23397/ > ----------------------------------------------------------- > > (Updated July 10, 2014, 5:24 p.m.) > > > Review request for accumulo. > > > Bugs: ACCUMULO-2984 > https://issues.apache.org/jira/browse/ACCUMULO-2984 > > > Repository: accumulo > > > Description > ------- > > Adds a change to SiteConfiguration to allow external setting of the xml > configuration file. > Adds a single method to MiniAccumuloConfig which allows a user to point to > accumulo-site.xml and HADOOP_CONF_DIR to use for pulling out requisite > instance information > Clusters configurations into those required to run inside a MAC-sized > footprint and those which are for arbitrary naming schemes for MAC > Provides flagging to prevent uneccessary folder creation > Provides flagging to prevent running zookeeper and initializing > > > Diffs > ----- > > core/src/main/java/org/apache/accumulo/core/conf/SiteConfiguration.java > 4c7d95e > > minicluster/src/main/java/org/apache/accumulo/minicluster/MiniAccumuloConfig.java > be80f85 > > minicluster/src/main/java/org/apache/accumulo/minicluster/impl/MiniAccumuloClusterImpl.java > 977968e > > minicluster/src/main/java/org/apache/accumulo/minicluster/impl/MiniAccumuloConfigImpl.java > 337eda0 > > Diff: https://reviews.apache.org/r/23397/diff/ > > > Testing > ------- > > Ran the following test code- > public class TestMACWithRealInstance { > public static void main(String args[]) throws IOException, > AccumuloException, AccumuloSecurityException, TableExistsException, > InterruptedException { > MiniAccumuloConfig macConfig = new MiniAccumuloConfig(new > File("/tmp/mac"), "secret"); > macConfig.setNumTservers(2); > macConfig.setMemory(ServerType.TABLET_SERVER, 2, MemoryUnit.GIGABYTE); > macConfig.useExistingInstance(new > File("/usr/lib/accumulo/conf/accumulo-site.xml"), new > File("/usr/lib/hadoop/conf")); > MiniAccumuloCluster mac = new MiniAccumuloCluster(macConfig); > mac.start(); > System.out.println("Started"); > mac.getConnector("root", "secret").tableOperations().create("macCreated"); > System.out.println("Stopping"); > mac.stop(); > System.out.println("Stopped"); > } > } > Which runs fine, except stopping issues which seem to be related to > ACCUMULO-2985 > > After running this, I validated that the table was created in the real > accumulo instance via zkCli > > > Thanks, > > John Vines > >
