> On July 28, 2014, 4:04 p.m., kturner wrote: > > When testing the 1.4 to 1.6 upgrade, did you test with and without walogs? > > Does the 1.5 to 1.6 upgrade still work ok after this patch? Did you do > > anything to verify delete entires for normal and metadata tablets when > > upgrading from 1.4 to 1.6? > > Sean Busbey wrote: > I mostly focused on testing with walogs present. I also tried a clean > shutdown, but I don't recall if that succeeded in avoiding all walogs. > > I forced delete entries by doing compactions (this is how I first found > ACCUMULO-2899. > > 1.5 to 1.6 upgrade should still be fine. I *think* I tested that, but to > be honest it's been too long now and I don't recall. > > Mike Drob wrote: > Just got done testing 1.5 upgrades to 1.6+this patch. Everything is green!
Keith, any other concerns? - Sean ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23413/#review48861 ----------------------------------------------------------- On July 26, 2014, 4:07 a.m., Sean Busbey wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/23413/ > ----------------------------------------------------------- > > (Updated July 26, 2014, 4:07 a.m.) > > > Review request for accumulo. > > > Bugs: ACCUMULO-2988 > https://issues.apache.org/jira/browse/ACCUMULO-2988 > > > Repository: accumulo > > > Description > ------- > > forward ports of some patches around 1.4 -> 1.5 upgrades to the 1.6 branch, > as well as new additions. > > > Diffs > ----- > > README c2c2446dc0312c64427c2d7205056c72b2cfdec2 > server/base/src/main/java/org/apache/accumulo/server/Accumulo.java > 68d862d5baaad04ff38789155c0fb60ac18f92b8 > server/base/src/main/java/org/apache/accumulo/server/ServerConstants.java > b577abbb72c9dce70b8f12dfefe381d38c48cb8e > > server/base/src/main/java/org/apache/accumulo/server/util/MetadataTableUtil.java > 374017d6544a3be5bccb70eab7a994a92f9693ac > server/master/src/main/java/org/apache/accumulo/master/Master.java > c367ae0c2febbb297924da4a87ef1d91104d94c4 > > Diff: https://reviews.apache.org/r/23413/diff/ > > > Testing > ------- > > ran through test upgrade > > * Install 1.4.5 > * Load a variety of table storage configs, each wi/156M cells (~4GB > uncompressed) > ** no compression, bloom filter on, block cache on > ** lzo compression, bloom filter off, block cache off > ** snappy compression, bloom filters on, block cache off > ** snappy compression, bloom filters off, block cache on > * Upgrade according to README to 1.6.1-SNAP+patches > * Verify correct contents readable > * force compaction > * restart cluster > * Verify correct contents readable > > > Thanks, > > Sean Busbey > >
