----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24855/#review51201 -----------------------------------------------------------
docs/src/main/asciidoc/design/ACCUMULO-1454-proposal-01.adoc <https://reviews.apache.org/r/24855/#comment89232> Clarification suggestion: s/Disable tablet assignment/Disable all tablet across the cluster/ docs/src/main/asciidoc/design/ACCUMULO-1454-proposal-01.adoc <https://reviews.apache.org/r/24855/#comment89234> I wouldn't want to depend on these specific scripts. I'd expect any actual implementation would be script-independent and that any restart mechanism for the tserver would be sufficient. docs/src/main/asciidoc/design/ACCUMULO-1454-proposal-01.adoc <https://reviews.apache.org/r/24855/#comment89240> We are relying on a decent balancer implementation here, which is reasonable. docs/src/main/asciidoc/design/ACCUMULO-1454-proposal-01.adoc <https://reviews.apache.org/r/24855/#comment89243> Would be nice to provide a (*very short*) convenience script in contrib to do this, given a list of tserver nodes (or that looks in ZK), just as an example of how to do this. docs/src/main/asciidoc/design/ACCUMULO-1454-proposal-01.adoc <https://reviews.apache.org/r/24855/#comment89245> Make sure that the method for initiating a clean shutdown does not depend on stop-here.sh, though stop-here.sh may use that method. docs/src/main/asciidoc/design/ACCUMULO-1454-proposal-01.adoc <https://reviews.apache.org/r/24855/#comment89246> Would these be idempotent, or would there be an error thrown if not in the expected state? I'd assume idempotent, but it's not clear here. docs/src/main/asciidoc/design/ACCUMULO-1454-proposal-01.adoc <https://reviews.apache.org/r/24855/#comment89247> We might want to seriously think about how we identify tservers in the API. String type is probably a bad idea. HostAndPort, or some unique assigned tserverID is probably better. This method could also take a set. docs/src/main/asciidoc/design/ACCUMULO-1454-proposal-01.adoc <https://reviews.apache.org/r/24855/#comment89248> Would this fail immediately if assignments are disabled? Or hang indefinitely (maybe with the occasional warning message)? - Christopher Tubbs On Aug. 20, 2014, 1:40 p.m., kturner wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/24855/ > ----------------------------------------------------------- > > (Updated Aug. 20, 2014, 1:40 p.m.) > > > Review request for accumulo. > > > Bugs: ACCUMULO-1454 > https://issues.apache.org/jira/browse/ACCUMULO-1454 > > > Repository: accumulo > > > Description > ------- > > Positing ACCUMULO-1454 design doc for review > > > Diffs > ----- > > docs/src/main/asciidoc/design/ACCUMULO-1454-proposal-01.adoc PRE-CREATION > > Diff: https://reviews.apache.org/r/24855/diff/ > > > Testing > ------- > > > Thanks, > > kturner > >
