----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25117/#review52302 -----------------------------------------------------------
core/src/main/java/org/apache/accumulo/core/client/BatchWriterConfig.java <https://reviews.apache.org/r/25117/#comment91060> Updated unit test. server/base/src/main/java/org/apache/accumulo/server/init/Initialize.java <https://reviews.apache.org/r/25117/#comment91065> Good point. I've added upgrade code to convert the tserver.wal.sync.method and table.walog.enabled to Durability. server/tserver/src/main/java/org/apache/accumulo/tserver/TabletServer.java <https://reviews.apache.org/r/25117/#comment91066> I've removed it. server/tserver/src/main/java/org/apache/accumulo/tserver/log/DfsLogger.java <https://reviews.apache.org/r/25117/#comment91067> LOG durability is expected, NONE is not. server/tserver/src/main/java/org/apache/accumulo/tserver/log/DfsLogger.java <https://reviews.apache.org/r/25117/#comment91068> Seems reasonable, but it will log an stack trace. server/tserver/src/main/java/org/apache/accumulo/tserver/log/DfsLogger.java <https://reviews.apache.org/r/25117/#comment91069> removed since I'm no longer logging the durability server/tserver/src/main/java/org/apache/accumulo/tserver/log/DfsLogger.java <https://reviews.apache.org/r/25117/#comment91070> removed server/tserver/src/main/java/org/apache/accumulo/tserver/log/DfsLogger.java <https://reviews.apache.org/r/25117/#comment91071> removed server/tserver/src/main/java/org/apache/accumulo/tserver/log/DfsLogger.java <https://reviews.apache.org/r/25117/#comment91072> removed server/tserver/src/main/java/org/apache/accumulo/tserver/log/DfsLogger.java <https://reviews.apache.org/r/25117/#comment91073> Done. server/tserver/src/main/java/org/apache/accumulo/tserver/log/TabletServerLogger.java <https://reviews.apache.org/r/25117/#comment91074> Done test/src/test/java/org/apache/accumulo/test/functional/DurabilityIT.java <https://reviews.apache.org/r/25117/#comment91075> Done - Eric Newton On Sept. 3, 2014, 9:42 p.m., Eric Newton wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/25117/ > ----------------------------------------------------------- > > (Updated Sept. 3, 2014, 9:42 p.m.) > > > Review request for accumulo, Josh Elser, kturner, and John Vines. > > > Bugs: ACCUMULO-1957 > https://issues.apache.org/jira/browse/ACCUMULO-1957 > > > Repository: accumulo > > > Description > ------- > > Allow tables and update sessions to be configured with different levels of > durability (WAL sync'ing). > > > Diffs > ----- > > core/src/main/java/org/apache/accumulo/core/client/BatchWriterConfig.java > e2ec22e > > core/src/main/java/org/apache/accumulo/core/client/ConditionalWriterConfig.java > 7671c35 > core/src/main/java/org/apache/accumulo/core/client/Durability.java > PRE-CREATION > > core/src/main/java/org/apache/accumulo/core/client/impl/ConditionalWriterImpl.java > f5e6dd2 > > core/src/main/java/org/apache/accumulo/core/client/impl/TabletServerBatchWriter.java > f2dd980 > core/src/main/java/org/apache/accumulo/core/client/impl/Writer.java bf226eb > core/src/main/java/org/apache/accumulo/core/conf/Property.java 9837867 > core/src/main/java/org/apache/accumulo/core/conf/PropertyType.java f39a8bd > > core/src/main/java/org/apache/accumulo/core/master/thrift/MasterClientService.java > 9c850a8 > > core/src/main/java/org/apache/accumulo/core/tabletserver/thrift/TDurability.java > PRE-CREATION > > core/src/main/java/org/apache/accumulo/core/tabletserver/thrift/TabletClientService.java > 2ba7674 > core/src/main/thrift/tabletserver.thrift 25e0b10 > > examples/simple/src/main/java/org/apache/accumulo/examples/simple/client/ReadWriteExample.java > a7b288d > server/base/src/main/java/org/apache/accumulo/server/init/Initialize.java > 9b952ba > server/tserver/src/main/java/org/apache/accumulo/tserver/Mutations.java > PRE-CREATION > > server/tserver/src/main/java/org/apache/accumulo/tserver/TabletMutations.java > e814f0e > server/tserver/src/main/java/org/apache/accumulo/tserver/TabletServer.java > 57e3dee > server/tserver/src/main/java/org/apache/accumulo/tserver/log/DfsLogger.java > c01e54a > > server/tserver/src/main/java/org/apache/accumulo/tserver/log/TabletServerLogger.java > 26e6891 > > server/tserver/src/main/java/org/apache/accumulo/tserver/session/ConditionalSession.java > 26668f6 > > server/tserver/src/main/java/org/apache/accumulo/tserver/session/UpdateSession.java > bc04a85 > > server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/CommitSession.java > 6402797 > server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/Tablet.java > 37950fc > > server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/TabletCommitter.java > a5d197c > test/src/main/java/org/apache/accumulo/test/WrongTabletTest.java aeba2e0 > > test/src/main/java/org/apache/accumulo/test/performance/thrift/NullTserver.java > 6c34172 > test/src/test/java/org/apache/accumulo/test/functional/DurabilityIT.java > PRE-CREATION > > test/src/test/java/org/apache/accumulo/test/functional/SessionDurabilityIT.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/25117/diff/ > > > Testing > ------- > > Added DurabilityIT. > > > Thanks, > > Eric Newton > >
