Github user joshelser commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/16#discussion_r18073417
--- Diff:
server/base/src/main/java/org/apache/accumulo/server/fs/VolumeChooser.java ---
@@ -18,5 +18,7 @@
public interface VolumeChooser {
+ String choose(VolumeChooserEnvironment env, String[] options);
--- End diff --
Plus, having duplicative methods like this is confusing for an
implementation (when does choose1() get called and when does choose2() get
called, why, etc). Maybe create some utility/helper method for implementations
to get the current VolumeChooserEnvironment?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
