----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26153/#review55044 -----------------------------------------------------------
test/src/test/java/org/apache/accumulo/test/MissingWalHeaderCompletesRecoveryIT.java <https://reviews.apache.org/r/26153/#comment95374> Could use the following here... MetadataSchema.TabletsSection.getRow(tableId, null); test/src/test/java/org/apache/accumulo/test/MissingWalHeaderCompletesRecoveryIT.java <https://reviews.apache.org/r/26153/#comment95377> I wonder if the test would work and run faster if the table was taken offline, metadata table modified, and then table brought back online. I have no problem w/ this approach, this was just something I thought of.. test/src/test/java/org/apache/accumulo/test/MissingWalHeaderCompletesRecoveryIT.java <https://reviews.apache.org/r/26153/#comment95376> this sleep should not be needed - kturner On Sept. 30, 2014, 11:01 p.m., Josh Elser wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/26153/ > ----------------------------------------------------------- > > (Updated Sept. 30, 2014, 11:01 p.m.) > > > Review request for accumulo. > > > Bugs: ACCUMULO-3182 > https://issues.apache.org/jira/browse/ACCUMULO-3182 > > > Repository: accumulo > > > Description > ------- > > Ensures that a WAL that was empty or missing a complete header (due to > tservers dying before it could happen) can be successfully recovered (by > assuming that the lack of a complete header means there is no data to > recover). Currently against master, will pull back to 1.5 and merge forward > since it likely affects all branches. > > > Diffs > ----- > > > server/base/src/main/java/org/apache/accumulo/server/log/SortedLogState.java > PRE-CREATION > > server/master/src/main/java/org/apache/accumulo/master/recovery/RecoveryManager.java > 791aec8 > server/tserver/src/main/java/org/apache/accumulo/tserver/TabletServer.java > b4fbfed > server/tserver/src/main/java/org/apache/accumulo/tserver/log/DfsLogger.java > 8de2b25 > server/tserver/src/main/java/org/apache/accumulo/tserver/log/LogSorter.java > 4badefa > > server/tserver/src/main/java/org/apache/accumulo/tserver/log/MultiReader.java > 541f075 > > server/tserver/src/main/java/org/apache/accumulo/tserver/logger/LogReader.java > 681fbd3 > > server/tserver/src/main/java/org/apache/accumulo/tserver/replication/AccumuloReplicaSystem.java > 416a86e > > server/tserver/src/test/java/org/apache/accumulo/tserver/log/MultiReaderTest.java > a79e77e > > server/tserver/src/test/java/org/apache/accumulo/tserver/log/SortedLogRecoveryTest.java > fffa15e > > server/tserver/src/test/java/org/apache/accumulo/tserver/log/TestUpgradePathForWALogs.java > f01ee10 > > test/src/test/java/org/apache/accumulo/test/MissingWalHeaderCompletesRecoveryIT.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/26153/diff/ > > > Testing > ------- > > New IT, ran UTs and ITs. > > > Thanks, > > Josh Elser > >
