> On July 15, 2014, 6:58 p.m., kturner wrote: > > minicluster/src/main/java/org/apache/accumulo/minicluster/MiniAccumuloConfig.java, > > line 267 > > <https://reviews.apache.org/r/23397/diff/4/?file=628112#file628112line267> > > > > A test to prevent regressions would be really nice. Might be able to > > start a mini instance, stop it, use internal exec methods to start a > > zookeeper, and then point another mac to the old mini instance. > > John Vines wrote: > I'm gonna be blunt - this is really really hard and I think it can be > punted to a ticket for future work > > kturner wrote: > I was going to try writing a test and see how it went, however the patch > does not apply to 1.6 branch for me. Below is the md5 of the patch I tried. > > md5sum 0001-ACCUMULO-2984-support-running-MAC-against-a-real-acc.patch > 68738fd6c45ce47a27ac21ae7d69f5f9 > 0001-ACCUMULO-2984-support-running-MAC-against-a-real-acc.patch > > John Vines wrote: > That's an old version. I uploaded an updated version last week > b2de90dfebf8ade591bd71b2e1ab36fe > 0001-ACCUMULO-2984-adding-ability-to-run-MAC-against-a-pe.patch > > John Vines wrote: > Uploaded again with one that git ams just fine. RB uses the patch command > so it's failing here. > > kturner wrote: > I downloaded the patch and it applied, however I am seeing a different > md5. > f8ff459e213d255f9a36698f8a6d7376 > 0001-ACCUMULO-2984-adding-ability-to-run-MAC-against-a-pe.patch > > John Vines wrote: > That matches the new uploaded version > > kturner wrote: > I wrote a test for this feature. One of the test hangs because of an > issue, I will comment on the problem. > > > https://github.com/keith-turner/accumulo/commit/79ad30129c5dc14e005843a9b992fa5dc24e4311
oh, that commit is in the following branch on my Accumulo fork if you want to clone. The branch has an older version of your patch. Would probably need the latest patch to avoid NPEs https://github.com/keith-turner/accumulo/tree/ACCUMULO-2984 - kturner ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23397/#review47792 ----------------------------------------------------------- On Oct. 20, 2014, 8:09 p.m., John Vines wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/23397/ > ----------------------------------------------------------- > > (Updated Oct. 20, 2014, 8:09 p.m.) > > > Review request for accumulo. > > > Bugs: ACCUMULO-2984 > https://issues.apache.org/jira/browse/ACCUMULO-2984 > > > Repository: accumulo > > > Description > ------- > > Adds a change to SiteConfiguration to allow external setting of the xml > configuration file. > Adds a single method to MiniAccumuloConfig which allows a user to point to > accumulo-site.xml and HADOOP_CONF_DIR to use for pulling out requisite > instance information > Clusters configurations into those required to run inside a MAC-sized > footprint and those which are for arbitrary naming schemes for MAC > Provides flagging to prevent uneccessary folder creation > Provides flagging to prevent running zookeeper and initializing > > > Diffs > ----- > > core/src/main/java/org/apache/accumulo/core/conf/SiteConfiguration.java > 9b65e7d > > minicluster/src/main/java/org/apache/accumulo/minicluster/MiniAccumuloConfig.java > be80f85 > > minicluster/src/main/java/org/apache/accumulo/minicluster/impl/MiniAccumuloClusterImpl.java > 5d8501e > > minicluster/src/main/java/org/apache/accumulo/minicluster/impl/MiniAccumuloConfigImpl.java > e9ad045 > > server/base/src/main/java/org/apache/accumulo/server/util/AccumuloStatus.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/23397/diff/ > > > Testing > ------- > > Ran the following test code- > public class TestMACWithRealInstance { > public static void main(String args[]) throws IOException, > AccumuloException, AccumuloSecurityException, TableExistsException, > InterruptedException { > MiniAccumuloConfig macConfig = new MiniAccumuloConfig(new > File("/tmp/mac"), "secret"); > macConfig.setNumTservers(2); > macConfig.setMemory(ServerType.TABLET_SERVER, 2, MemoryUnit.GIGABYTE); > macConfig.useExistingInstance(new > File("/usr/lib/accumulo/conf/accumulo-site.xml"), new > File("/usr/lib/hadoop/conf")); > MiniAccumuloCluster mac = new MiniAccumuloCluster(macConfig); > mac.start(); > System.out.println("Started"); > mac.getConnector("root", "secret").tableOperations().create("macCreated"); > System.out.println("Stopping"); > mac.stop(); > System.out.println("Stopped"); > } > } > Which runs fine, except stopping issues which seem to be related to > ACCUMULO-2985 > > After running this, I validated that the table was created in the real > accumulo instance via zkCli > > > Thanks, > > John Vines > >
