----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26530/#review57647 -----------------------------------------------------------
server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/Tablet.java <https://reviews.apache.org/r/26530/#comment98450> Same thing here too. It would be nice to fold this into always having a non-null CompactionStrategy and when the user did not provide one (does the system-issued compactions hit here?), we have a EverythingCompactionStrategy. - Josh Elser On Oct. 16, 2014, 2:10 a.m., kturner wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/26530/ > ----------------------------------------------------------- > > (Updated Oct. 16, 2014, 2:10 a.m.) > > > Review request for accumulo. > > > Bugs: ACCUMULO-1798 > https://issues.apache.org/jira/browse/ACCUMULO-1798 > > > Repository: accumulo > > > Description > ------- > > This patch generated w/o thrift using the following command. > > git diff HEAD~1 -- core server shell test proxy/src/main/thrift/proxy.thrift > proxy/src/main/java/org/apache/accumulo/proxy/ProxyServer.java > > The issue has the full patch. > > > Diffs > ----- > > > core/src/main/java/org/apache/accumulo/core/client/admin/CompactionConfig.java > PRE-CREATION > > core/src/main/java/org/apache/accumulo/core/client/admin/CompactionStrategyConfig.java > PRE-CREATION > > core/src/main/java/org/apache/accumulo/core/client/admin/TableOperations.java > 97f538d > > core/src/main/java/org/apache/accumulo/core/client/impl/CompactionStrategyConfigUtil.java > PRE-CREATION > > core/src/main/java/org/apache/accumulo/core/client/impl/TableOperationsImpl.java > e46b9c9 > > core/src/main/java/org/apache/accumulo/core/client/mock/MockTableOperations.java > 08750fe > > core/src/test/java/org/apache/accumulo/core/client/impl/TableOperationsHelperTest.java > 02838ed > proxy/src/main/java/org/apache/accumulo/proxy/ProxyServer.java a778add > proxy/src/main/thrift/proxy.thrift fbd9c52 > > server/base/src/main/java/org/apache/accumulo/server/master/tableOps/CompactionIterators.java > 4f5bf42 > > server/base/src/main/java/org/apache/accumulo/server/master/tableOps/UserCompactionConfig.java > PRE-CREATION > > server/master/src/main/java/org/apache/accumulo/master/FateServiceHandler.java > 41ca911 > > server/master/src/main/java/org/apache/accumulo/master/tableOps/CompactRange.java > dedfb97 > server/tserver/src/main/java/org/apache/accumulo/tserver/TabletServer.java > 2e1eb2c > > server/tserver/src/main/java/org/apache/accumulo/tserver/TabletServerResourceManager.java > 4855a4f > > server/tserver/src/main/java/org/apache/accumulo/tserver/compaction/CompactionPlan.java > 6f69fb0 > > server/tserver/src/main/java/org/apache/accumulo/tserver/compaction/CompactionStrategy.java > 7bc1a80 > > server/tserver/src/main/java/org/apache/accumulo/tserver/compaction/DefaultCompactionStrategy.java > 8b03d17 > > server/tserver/src/main/java/org/apache/accumulo/tserver/compaction/EverythingCompactionStrategy.java > PRE-CREATION > > server/tserver/src/main/java/org/apache/accumulo/tserver/compaction/SizeLimitCompactionStrategy.java > 478939a > server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/Tablet.java > 0194778 > shell/src/main/java/org/apache/accumulo/shell/commands/CompactCommand.java > 80dd9ba > test/src/test/java/org/apache/accumulo/proxy/SimpleProxyIT.java 6b4bcfb > test/src/test/java/org/apache/accumulo/test/ShellServerIT.java 5a068af > test/src/test/java/org/apache/accumulo/test/UserCompactionStrategyIT.java > PRE-CREATION > > test/src/test/java/org/apache/accumulo/test/functional/FunctionalTestUtils.java > 1246efe > > Diff: https://reviews.apache.org/r/26530/diff/ > > > Testing > ------- > > mvn package so far > > > Thanks, > > kturner > >
