> On Dec. 5, 2014, 9:54 p.m., Mike Drob wrote: > > server/tserver/src/main/java/org/apache/accumulo/tserver/compaction/strategies/ConfigurableCompactionStrategy.java, > > line 39 > > <https://reviews.apache.org/r/28739/diff/3/?file=784037#file784037line39> > > > > I know we're not on Java 8, but it would still be nice if this could > > easily be retro-fitted to > > https://docs.oracle.com/javase/8/docs/api/java/util/function/BiPredicate.html > > when we get to that point. Or maybe the specific tests can implement > > BiPredicate.
Thats neat. We can refactor when we get there. > On Dec. 5, 2014, 9:54 p.m., Mike Drob wrote: > > test/src/test/java/org/apache/accumulo/test/ShellServerIT.java, line 770 > > <https://reviews.apache.org/r/28739/diff/3/?file=784040#file784040line770> > > > > It bothers me that these are not in alphabetical order. :) > > > > Not worth fixing, but it just looked strange at first glance and I > > couldn't figure out why. Not what I intended, but it was late. I'll leave it, it makes the test slightly more interesting. > On Dec. 5, 2014, 9:54 p.m., Mike Drob wrote: > > shell/src/main/java/org/apache/accumulo/shell/commands/CompactCommand.java, > > line 133 > > <https://reviews.apache.org/r/28739/diff/3/?file=784039#file784039line133> > > > > Should not be using System.out good catch... I meant to take that out. Had added it at some point to debug something. - kturner ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28739/#review64089 ----------------------------------------------------------- On Dec. 5, 2014, 10:43 p.m., kturner wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/28739/ > ----------------------------------------------------------- > > (Updated Dec. 5, 2014, 10:43 p.m.) > > > Review request for accumulo. > > > Bugs: ACCUMULO-3134 > https://issues.apache.org/jira/browse/ACCUMULO-3134 > > > Repository: accumulo > > > Description > ------- > > Added file selection and output configuration to shell compact command > > > Diffs > ----- > > > core/src/main/java/org/apache/accumulo/core/compaction/CompactionSettings.java > PRE-CREATION > > server/tserver/src/main/java/org/apache/accumulo/tserver/compaction/strategies/ConfigurableCompactionStrategy.java > PRE-CREATION > > server/tserver/src/test/java/org/apache/accumulo/tserver/compaction/strategies/ConfigurableCompactionStrategyTest.java > PRE-CREATION > shell/src/main/java/org/apache/accumulo/shell/Shell.java 8927ee0 > shell/src/main/java/org/apache/accumulo/shell/commands/CompactCommand.java > 660630e > test/src/test/java/org/apache/accumulo/test/ShellServerIT.java d878c7f > > Diff: https://reviews.apache.org/r/28739/diff/ > > > Testing > ------- > > Added an IT that test file selection options on compact command. IT does not > test output file configuration. > > > Thanks, > > kturner > >
