> On Dec. 18, 2014, 4:19 p.m., Josh Elser wrote: > > core/src/main/java/org/apache/accumulo/core/file/rfile/MetricsGatherer.java, > > line 36 > > <https://reviews.apache.org/r/29176/diff/1/?file=795044#file795044line36> > > > > Why the concurrent maps? I don't see anything in these changes that > > would require it now, do you have plans for something else in the future?
These keep separate metrics. One for the density of that metric in the locality group and the other for how many blocks in that locality group this visiblity is seen in. - Jenna ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29176/#review65499 ----------------------------------------------------------- On Dec. 17, 2014, 8:31 p.m., Jenna Huston wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/29176/ > ----------------------------------------------------------- > > (Updated Dec. 17, 2014, 8:31 p.m.) > > > Review request for accumulo. > > > Bugs: ACCUMULO-3420 > https://issues.apache.org/jira/browse/ACCUMULO-3420 > > > Repository: accumulo > > > Description > ------- > > Added an option to PrintInfo to get visibility metrics. Prints the number of > times a visibilty is seen in each locality group. Also shows how many blocks > in the locality group have his visibiltiy. > > > Diffs > ----- > > core/src/main/java/org/apache/accumulo/core/file/rfile/MetricsGatherer.java > PRE-CREATION > core/src/main/java/org/apache/accumulo/core/file/rfile/PrintInfo.java > 43586dd > core/src/main/java/org/apache/accumulo/core/file/rfile/RFile.java 9dcb3a5 > > Diff: https://reviews.apache.org/r/29176/diff/ > > > Testing > ------- > > Tested with a few RFiles that I made. > > > Thanks, > > Jenna Huston > >
