> On Jan. 6, 2015, 9:41 p.m., Eric Newton wrote: > > server/base/src/main/java/org/apache/accumulo/server/master/balancer/GroupBalancer.java, > > line 674 > > <https://reviews.apache.org/r/29230/diff/1/?file=796995#file796995line674> > > > > Could this class be made static by passing in the table ID?
inner class also uses `context`. - kturner ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29230/#review66915 ----------------------------------------------------------- On Jan. 7, 2015, 7:52 p.m., kturner wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/29230/ > ----------------------------------------------------------- > > (Updated Jan. 7, 2015, 7:52 p.m.) > > > Review request for accumulo. > > > Bugs: ACCUMULO-3439 > https://issues.apache.org/jira/browse/ACCUMULO-3439 > > > Repository: accumulo > > > Description > ------- > > The patch contains a new balancer, test, and documentation. > > > Diffs > ----- > > docs/src/main/resources/examples/README.rgbalancer PRE-CREATION > > server/base/src/main/java/org/apache/accumulo/server/master/balancer/GroupBalancer.java > PRE-CREATION > > server/base/src/main/java/org/apache/accumulo/server/master/balancer/RegexGroupBalancer.java > PRE-CREATION > > server/base/src/main/java/org/apache/accumulo/server/master/balancer/TableLoadBalancer.java > 5eae890 > > server/base/src/test/java/org/apache/accumulo/server/master/balancer/GroupBalancerTest.java > PRE-CREATION > > test/src/test/java/org/apache/accumulo/test/functional/RegexGroupBalanceIT.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/29230/diff/ > > > Testing > ------- > > The new unit test and intergeration test added in the patch run. > > > Thanks, > > kturner > >
