I also ran the compliance checker tool. The only other changes were in o.a.a.core.data.KeyValue. But that class is not listed as part of public API. The changes showed up in the report because the class was in data package.
On Wed, Jan 21, 2015 at 6:01 PM, Christopher <[email protected]> wrote: > On Wed, Jan 21, 2015 at 11:05 AM, Sean Busbey <[email protected]> wrote: > > > On Wed, Jan 21, 2015 at 6:57 AM, <[email protected]> wrote: > > > > > I concur. This change makes the version of this release 1.7.0. We > either > > > need to change the version or remove the method. Good catch. Out of > > > curiosity, did you find this by visual inspection or with a tool? > > > > > > > > While I have many eyes, they don't generally get spent on comprehensive > > code reviews. ;) > > > > I used the Java API Compatibility Checker. > > > > > > > Was that the only violation? > > (Also, -1 for the same reason.) >
