> On Jan. 30, 2015, 6:34 p.m., Mike Drob wrote: > > Another thought I had was that it would be good to establish the start > > commands as some sort of public facing interface (not quite API... a human > > interface) and hold ourselves to various compat promises on these. We've > > already implicitly encouraged operators to build tooling around our exposed > > shell primitives, so we should try to be nice to them where possible. > > > > Fine to do in follow on work.
I did make effort to ensure the start commands maintained the ability to launch with the main methods. Beyond that, things like their arguments, behavior, etc., I agree it would be a good idea to maintain compat, but it's outside the scope of this work (which preserved all existing behavior). I do think we've probably been pretty good at maintaining compat with these. At the very least, they don't change frequently (not since the big jcommander update). And, a big "eek" on the "implicitly encouraged operators to build tooling around our exposed shell primitives". I have actively discouraged that, except for basic one-time things. If people need to do anything routinely, I've recommended they use the API, not the shell. In any case, the shell compat is also probably a worthwhile issue to address, but also (well) outside the scope of this. - Christopher ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30382/#review70446 ----------------------------------------------------------- On Jan. 30, 2015, 5:06 p.m., Christopher Tubbs wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30382/ > ----------------------------------------------------------- > > (Updated Jan. 30, 2015, 5:06 p.m.) > > > Review request for accumulo. > > > Bugs: ACCUMULO-1844 and ACCUMULO-3514 > https://issues.apache.org/jira/browse/ACCUMULO-1844 > https://issues.apache.org/jira/browse/ACCUMULO-3514 > > > Repository: accumulo > > > Description > ------- > > ACCUMULO-3514 Use auto-service for start > > Use @AutoService annotations and Java's ServiceLoader mechanism to > discover > classes which are executable by Accumulo's "start" jar with a keyword. > > This replaces manual intervention whenever we add a new option to the > bin/accumulo script and also auto-populates the usage for that script. > > > Diffs > ----- > > core/pom.xml 5fc7a6e > core/src/main/java/org/apache/accumulo/core/file/rfile/PrintInfo.java > f29efcc > core/src/main/java/org/apache/accumulo/core/util/Classpath.java > PRE-CREATION > core/src/main/java/org/apache/accumulo/core/util/CreateToken.java 79b241c > core/src/main/java/org/apache/accumulo/core/util/Help.java PRE-CREATION > core/src/main/java/org/apache/accumulo/core/util/Jar.java PRE-CREATION > core/src/main/java/org/apache/accumulo/core/util/Version.java ee645ff > minicluster/pom.xml ee6cdc8 > > minicluster/src/main/java/org/apache/accumulo/minicluster/MiniAccumuloRunner.java > c45abc0 > > minicluster/src/main/java/org/apache/accumulo/minicluster/impl/MiniClusterExecutable.java > PRE-CREATION > pom.xml dda1cfe > proxy/pom.xml 9312d7b > proxy/src/main/java/org/apache/accumulo/proxy/Proxy.java 0a4d12e > server/base/pom.xml c21a168 > server/base/src/main/java/org/apache/accumulo/server/init/Initialize.java > 0a1f411 > server/base/src/main/java/org/apache/accumulo/server/util/Admin.java > 77d5ea1 > server/base/src/main/java/org/apache/accumulo/server/util/Info.java 29fa135 > > server/base/src/main/java/org/apache/accumulo/server/util/LoginProperties.java > be5a7c8 > > server/base/src/main/java/org/apache/accumulo/server/util/ZooKeeperMain.java > 0edcf71 > server/gc/pom.xml 9602b95 > server/gc/src/main/java/org/apache/accumulo/gc/GCExecutable.java > PRE-CREATION > server/master/pom.xml 7e9ab1d > > server/master/src/main/java/org/apache/accumulo/master/MasterExecutable.java > PRE-CREATION > server/monitor/pom.xml ba61aeb > > server/monitor/src/main/java/org/apache/accumulo/monitor/MonitorExecutable.java > PRE-CREATION > server/tracer/pom.xml ac9f45f > > server/tracer/src/main/java/org/apache/accumulo/tracer/TracerExecutable.java > PRE-CREATION > server/tserver/pom.xml cd0f8ef > > server/tserver/src/main/java/org/apache/accumulo/tserver/TServerExecutable.java > PRE-CREATION > shell/pom.xml db3530f > shell/src/main/java/org/apache/accumulo/shell/Shell.java a64ff45 > start/src/main/java/org/apache/accumulo/start/Main.java c820883 > start/src/main/java/org/apache/accumulo/start/spi/KeywordExecutable.java > PRE-CREATION > start/src/test/java/org/apache/accumulo/start/MainTest.java 1ea22fb > test/src/test/java/org/apache/accumulo/start/KeywordStartIT.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/30382/diff/ > > > Testing > ------- > > > Thanks, > > Christopher Tubbs > >
