Github user keith-turner commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/22#discussion_r26576497
--- Diff:
server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/Tablet.java ---
@@ -2022,6 +2029,16 @@ protected AccumuloConfiguration
createTableConfiguration(TableConfiguration base
private Set<FileRef> removeSmallest(Map<FileRef,DataFileValue>
filesToCompact, int maxFilesToCompact) {
// ensure this method works properly when multiple files have the same
size
+ // short-circuit; also handles zero files case
+ if (filesToCompact.size() <= maxFilesToCompact) {
+ Set<FileRef> smallestFiles = new
HashSet<FileRef>(filesToCompact.size());
--- End diff --
could do
```java
Set<FileRef> smallestFiles = new
HashSet<FileRef>(filesToCompact.keySet());
filesToCompact.clear();
return smallestFiles;
```
slightly easier to read than for loop
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
