Github user joshelser commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/25#discussion_r27826429
--- Diff:
core/src/main/java/org/apache/accumulo/core/client/mapreduce/AbstractInputFormat.java
---
@@ -426,6 +442,7 @@ protected static ClientConfiguration
getClientConfiguration(JobContext context)
* the table name for which the scanner is configured
* @since 1.6.0
*/
+ @Deprecated
protected abstract void setupIterators(TaskAttemptContext context,
Scanner scanner, String tableName, RangeInputSplit split);
--- End diff --
I think we could have source compatibility with a switch from Scanner to
ScannerBase, but I can't think of a way to handle AccumuloInputSplit instead of
only RangeInputSplits. It should be straightforward to just call a new
`setupIterator` method from the existing (now deprecated) method, no? Are you
just trying to reduce the amount of code in here?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
