Github user joshelser commented on the pull request:
https://github.com/apache/accumulo/pull/28#issuecomment-93887215
Overall this looks pretty good, but needs a little bit of touch up still.
Nice work Keith and Christopher, this took some doing. Some general thoughts:
* DelegationToken move is awkward to me. I think this should be in public
API and we just hide the impl details.
* Regarding what to do with the `crypto` package, can we get @ohshazbot
attention maybe? Perhaps he can help give some insight. I think it was designed
to be extendable by users (`CryptoModule` and `SecretKeyEncryptionStrategy`),
but there seems to be a lot of other stuff in there that shouldn't be (or be in
an impl). Maybe we can get this figured out for 1.7.0 so we can start the
deprecation cycle to remove the bits which shouldn't be there?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
