The basic pattern is:
1. create/identify a relevant JIRA
2. comment / indicate a willingness to work on the issue (on the
mailing list or in JIRA)
3. discuss possible solutions (if applicable)
4. create a patch
5. do one (or more) of:
pull request against github/apache/accumulo mirror (with reference
to ACCUMULO-xxxx)
attach patch (preferably git-formatted patch) to JIRA issue
create review on https://reviews.apache.org (put link to review in JIRA)
--
Christopher L Tubbs II
http://gravatar.com/ctubbsii
On Tue, Jun 16, 2015 at 4:29 PM, Leon Xu <[email protected]> wrote:
> Thanks Chris and Jose.
>
> Now the build is successful.
> I am wondering if I'd like to fix these kinds of bugs and make it as a
> starting point of being a contributor for Accumulo.
> What's the general process for doing this? e.g. branch out the code, make
> changes, send code-review etc.
>
> Is there any guidelines for doing this?
>
> Thanks
> Leon
>
> On Tue, Jun 16, 2015 at 1:04 PM, Christopher <[email protected]> wrote:
>
>> I fixed the findbugs and related issues locally, but haven't pushed it
>> yet, because now I'm seeing failures in
>> CloseWriteAheadLogReferencesTest. It's not the first time. Is this a
>> current known problem?
>>
>> --
>> Christopher L Tubbs II
>> http://gravatar.com/ctubbsii
>>
>>
>> On Tue, Jun 16, 2015 at 3:18 PM, Josh Elser <[email protected]> wrote:
>> > Or -Drat.ignoreErrors
>> >
>> >
>> > Christopher wrote:
>> >>
>> >> I thought I nuked that file... I'll take a look at that. In the
>> >> meantime, you can comment out the mrit module in the root pom.xml.
>> >>
>> >> --
>> >> Christopher L Tubbs II
>> >> http://gravatar.com/ctubbsii
>> >>
>> >>
>> >> On Tue, Jun 16, 2015 at 2:18 PM, Leon Xu<[email protected]>
>> >> wrote:
>> >>>
>> >>> Thanks Josh. That help skip the findbugs.
>> >>>
>> >>> I am then running into another issue which failed the build:
>> >>>
>> >>> *Failed to execute goal org.apache.rat:apache-rat-plugin:0.11:check
>> >>> (check-licenses) on project accumulo-mrit: Too many files with
>> unapproved
>> >>> license: 1 See RAT report in:
>> >>> /Users/leoxu/Projects/accumulo/mrit/target/rat.txt*
>> >>>
>> >>>
>> >>> Taking a look at the RAT report, it shows:
>> >>>
>> >>> *JavaDocs are generated and so license header is optional
>> >>> Generated files do not required license headers
>> >>>
>> >>> 1 Unknown Licenses
>> >>>
>> >>> *******************************
>> >>>
>> >>> Unapproved licenses:
>> >>>
>> >>> /Users/leoxu/Projects/accumulo/mrit/dependency-reduced-pom.xml
>> >>>
>> >>> ********************************
>> >>>
>> >>> *......*
>> >>>
>> >>>
>> >>> The file 'dependency-reduced-pom.xml' is auto-generated.
>> >>>
>> >>> Any idea on this issue?
>> >>>
>> >>>
>> >>> Thanks
>> >>> Leon
>> >>>
>> >>> On Tue, Jun 16, 2015 at 8:10 AM, Josh Elser<[email protected]>
>> wrote:
>> >>>
>> >>>> They're bugs that were committed by someone and need to be fixed.
>> >>>>
>> >>>> If you don't care about them and just want to build, you can provide
>> >>>> `-Dfindbugs.skip` on the command line when you build.
>> >>>>
>> >>>> Leon Xu wrote:
>> >>>>
>> >>>>> Hi Accumulo devs,
>> >>>>>
>> >>>>> I am checking out the accumulo master branch and try to build it by
>> >>>>> running:
>> >>>>> *mvn package -P assemble -DskipTests*
>> >>>>> Just want to give a try so I skip tests to save time.
>> >>>>>
>> >>>>> But I am getting the following error when it is building the
>> *Testing*
>> >>>>> Module.
>> >>>>>
>> >>>>> [INFO] BugInstance size is 2
>> >>>>> [INFO] Error size is 0
>> >>>>> [INFO] Total bugs: 2
>> >>>>> [INFO] Exceptional return value of java.io.File.mkdirs() ignored in
>> >>>>> org.apache
>> >>>>> .accumulo.test.UserCompactionStrategyIT.testPerTableClasspath() [
>> >>>>> org.apache.ac
>> >>>>> cumulo.test.UserCompactionStrategyIT] At
>> >>>>> UserCompactionStrategyIT.java:[line 1
>> >>>>> 36]
>> >>>>> [INFO] Usage of GetResource in
>> >>>>> org.apache.accumulo.test.proxy.SimpleProxyBase.
>> >>>>> testCompactionStrategy() may be unsafe if class is extended
>> >>>>> [org.apache.accumu
>> >>>>> lo.test.proxy.SimpleProxyBase] At SimpleProxyBase.java:[line 2251]
>> >>>>> [INFO]
>> >>>>>
>> >>>>> Can anyone shed some lights on it?
>> >>>>>
>> >>>>>
>> >>>>> Leon
>> >>>>>
>> >>>>>
>> >
>>
