Github user joshelser commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/47#discussion_r40052520
--- Diff:
core/src/main/java/org/apache/accumulo/core/iterators/Combiner.java ---
@@ -240,15 +299,18 @@ public void init(SortedKeyValueIterator<Key,Value>
source, Map<String,String> op
newInstance.setSource(getSource().deepCopy(env));
newInstance.combiners = combiners;
newInstance.combineAllColumns = combineAllColumns;
+ newInstance.isPartialCompaction = isPartialCompaction;
+ newInstance.deleteHandlingAction = deleteHandlingAction;
return newInstance;
}
@Override
public IteratorOptions describeOptions() {
IteratorOptions io = new IteratorOptions("comb", "Combiners apply
reduce functions to multiple versions of values with otherwise equal keys",
null, null);
- io.addNamedOption(ALL_OPTION, "set to true to apply Combiner to every
column, otherwise leave blank. if true, " + COLUMNS_OPTION
- + " option will be ignored.");
+ io.addNamedOption(ALL_OPTION,
+ "set to true to apply Combiner to every column, otherwise leave
blank. if true, " + COLUMNS_OPTION + " option will be ignored.");
io.addNamedOption(COLUMNS_OPTION, "<col fam>[:<col qual>]{,<col
fam>[:<col qual>]} escape non-alphanum chars using %<hex>.");
+ // TODO
--- End diff --
Did you forget todo something?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
