Github user ctubbsii commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/47#discussion_r40147270
--- Diff:
core/src/main/java/org/apache/accumulo/core/iterators/Combiner.java ---
@@ -313,4 +392,48 @@ public static void setColumns(IteratorSetting is,
List<IteratorSetting.Column> c
public static void setCombineAllColumns(IteratorSetting is, boolean
combineAllColumns) {
is.addOption(ALL_OPTION, Boolean.toString(combineAllColumns));
}
+
+ /**
+ * @since 1.6.4 1.7.1 1.8.0
--- End diff --
Instead of offering the options `IGNORE` and `LOG_ERROR`, we should
probably just always log a warning (if `REDUCE_ON_FULL_COMPACTION_ONLY` is not
set) and let users disable it in the log4j config, rather than in code.
The `REDUCE_ON_FULL_COMPACTION_ONLY` should be treated as a distinct
boolean value which can be set to `true` or `false` as a normal iterator option
(similar to `Filter`'s `negate` option), with a default value of `false` to
preserve existing behavior.
That would also minimize API changes, especially for 1.6.x and 1.7.x. While
this isn't technically public API, it'd still be good to minimize API impact on
users using those versions.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
