Github user keith-turner commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/56#discussion_r46292326
--- Diff:
server/base/src/main/java/org/apache/accumulo/server/util/RpcWrapper.java ---
@@ -36,20 +42,51 @@
* @since 1.6.1
*/
public class RpcWrapper {
+ private static final Logger log =
LoggerFactory.getLogger(RpcWrapper.class);
+
+ public static <T> T service(final T instance,
@SuppressWarnings("rawtypes") final Map<String,ProcessFunction<T,? extends
TBase>> processorView) {
+ // Get a handle on the isOnewayMethod and make it accessible
+ final Method isOnewayMethod;
+ try {
+ isOnewayMethod = ProcessFunction.class.getDeclaredMethod("isOneway");
--- End diff --
ugh... looking at this code make me realize how brittle this new workaround
and the existing work around are. Brittle in the sense that we are expecting
very specific Thrift internal behavior and method names, which could change in
Thrift at any time. I suppose we should look into pushing changes and/or test
upstream that verify some sort of expected behavior.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
