> On Feb. 24, 2016, 7:15 p.m., Josh Elser wrote: > > core/src/main/java/org/apache/accumulo/core/client/impl/TabletServerBatchWriter.java, > > line 974 > > <https://reviews.apache.org/r/43957/diff/1/?file=1268376#file1268376line974> > > > > Don't need to specify the parameterization of the HashMap > > Dave Marion wrote: > Why wouldn't you set the size on the map to avoid the overhead of growing > it? > > Josh Elser wrote: > The parameterization, not the arguments "String,List<Mutation>" is > unnecessary.
Gotcha - Dave ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43957/#review120541 ----------------------------------------------------------- On Feb. 24, 2016, 8:53 p.m., Dave Marion wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/43957/ > ----------------------------------------------------------- > > (Updated Feb. 24, 2016, 8:53 p.m.) > > > Review request for accumulo and Josh Elser. > > > Repository: accumulo > > > Description > ------- > > ACCUMULO-1755: removed synchronized modifier from > TabletServerBatchWriterstartProcessing() > > > Diffs > ----- > > > core/src/main/java/org/apache/accumulo/core/client/impl/TabletServerBatchWriter.java > bc90d00 > > Diff: https://reviews.apache.org/r/43957/diff/ > > > Testing > ------- > > unit tests in core pass > > > Thanks, > > Dave Marion > >
