Github user wjsl commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/73#discussion_r54022815
--- Diff:
core/src/main/java/org/apache/accumulo/core/file/rfile/bcfile/Compression.java
---
@@ -147,25 +148,27 @@ public synchronized OutputStream
createCompressionStream(OutputStream downStream
},
GZ(COMPRESSION_GZ) {
- private transient DefaultCodec codec;
+ private transient AtomicReference<DefaultCodec> codec = new
AtomicReference<DefaultCodec>();
@Override
- synchronized CompressionCodec getCodec() {
- if (codec == null) {
- codec = new DefaultCodec();
- codec.setConf(conf);
+ CompressionCodec getCodec() {
+ DefaultCodec resultCodec = codec.get();
+ if (null == resultCodec) {
+ DefaultCodec newCodec = new DefaultCodec();
--- End diff --
Why not just share a singleton codec instance for each kind of codec?
Looking at the implementations (Default, Gzip, Bzip2), they're all effectively
stateless (sans the Configuration object you can set on them) because they're
factories for streams.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
